feat(cli): freeze agent-substrate @v1 schemas and contract tests#14794
Draft
stevencartavia wants to merge 2 commits into
Draft
feat(cli): freeze agent-substrate @v1 schemas and contract tests#14794stevencartavia wants to merge 2 commits into
stevencartavia wants to merge 2 commits into
Conversation
This comment was marked as spam.
This comment was marked as spam.
p5hzehxa
reviewed
May 16, 2026
Transitive dep of jsonschema (foundry-test-utils only). Pulled in by the new schema validation harness from PR #14794. Amp-Thread-ID: https://ampcode.com/threads/T-019e2eb6-1816-72f5-87a7-a0c6297e9dd8 Co-authored-by: Amp <amp@ampcode.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update (deny.toml):** the new
jsonschematest dep transitively pulls inborrow-or-share, which is licensedMIT-0(MIT No Attribution).Stacked on #14791.
Commits a JSON Schema (Draft 2020-12) for every shipped foundry:*@v1 identifier under docs/agents/schemas/ and wires schema validation into the existing machine-mode tests so the production code paths are pinned against the committed contract.
Also adds:
binary-level agent_contract.rs tests for forge and cast covering --introspect, --machine --help, and --machine
CI guards that prevent dangling schema refs and pin exact result_schema_ref / event_schema_ref per adopted command
additive chain.broadcast_failed diagnostic for upcoming chain-write commands (script.broadcast_failed is untouched)
docs updates for --markdown-help deprecation, --json clarification, and chain-write retry-safety
No new commands are adopted; this PR locks down the contract already shipped by the previous PRs.