Add JSON warning envelope for forge config --fix#14800
Closed
Keemosty12 wants to merge 1 commit into
Closed
Conversation
Keemosty12
requested review from
0xrusowsky,
DaniPopes,
figtracer,
grandizzy,
mablr,
mattsse,
stevencartavia and
zerosnacks
as code owners
May 17, 2026 13:42
Contributor
|
This pull request is stale because it has been open for 14 days with no activity. It will be closed in 7 days if there is no further activity. |
Contributor
|
This pull request was closed because it has been inactive for 7 days since being marked as stale. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
forge config --fix --jsonwas still emitting warnings throughstderrtext output, so JSON consumers could not reliably parse warnings from the command result. This is inconsistent with the new JSON envelope direction and makes automation harder.Solution
This change makes the
--jsonpath return warnings inside the standard JSON success envelope (warnings[]) using structuredJsonMessageentries (code: config.fix), while keeping non-JSON behavior unchanged (sh_warn!).It also adds a CLI test,
config_fix_json_envelope_contains_structured_warnings, to verify the envelope shape and warning fields.PR Checklist