feat(cast): sign Tempo key authorizations with browser wallets#14810
Closed
figtracer wants to merge 1 commit into
Closed
feat(cast): sign Tempo key authorizations with browser wallets#14810figtracer wants to merge 1 commit into
figtracer wants to merge 1 commit into
Conversation
Contributor
|
This pull request is stale because it has been open for 14 days with no activity. It will be closed in 7 days if there is no further activity. |
figtracer
changed the title
figtracer
force-pushed
the
feat/tempo-browser-eip712-pr
branch
from
d726994 to
06030b3
Compare
Member
Author
|
superseded by #14743 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This retargets the PR away from Tempo transaction EIP-712 signing and toward the narrower KeyAuth flow.
cast key-auth encodefor RLP-encoding unsigned TempoKeyAuthorizationpayloads.cast key-auth signfor producing RLP-encodedSignedKeyAuthorizationpayloads.cast key-auth sign --browser, which asks the connected browser wallet to sign theKeyAuthorizationdirectly through the newfoundry-walletsKeyAuth API.--browseris not used.foundry-walletsto the revision that exposes browser/passkey KeyAuthorization signing.This intentionally does not add EIP-712 signing for Tempo transactions.
Conflict resolution
Rebased the PR branch onto current
origin/masterand kept only the KeyAuth browser-wallet signing delta.Validation
cargo +1.95.0 check -p cast@1.7.2cargo +1.95.0 fmt --package cast --check