Skip to content

fix(cast): parse tempo scope signatures#14979

Merged
mattsse merged 1 commit into
masterfrom
mattsse/fix-tempo-scope-parser
May 30, 2026
Merged

fix(cast): parse tempo scope signatures#14979
mattsse merged 1 commit into
masterfrom
mattsse/fix-tempo-scope-parser

Conversation

@mattsse
Copy link
Copy Markdown
Member

@mattsse mattsse commented May 30, 2026

Summary

  • parse Tempo policy function signatures through the shared ABI parser used by cast sig
  • split scope selector lists only at commas outside function parameter lists
  • preserve multi-recipient selector rules and reject empty selector or recipient entries

Root Cause

Tempo policy scopes split selector specs with a raw comma split, so full function signatures like transfer(address,uint256) were split in the middle of their parameter list. The selector parser also hashed any string containing parentheses directly, which let malformed signatures through instead of using the normal ABI parser.

Impact

cast keychain and cast wallet session create can now accept full function signatures in --scope entries, including signatures with comma-separated parameters, while keeping the existing shorthand and 4-byte selector forms.

@mattsse mattsse force-pushed the mattsse/fix-tempo-scope-parser branch from b3c44bb to 16e13c0 Compare May 30, 2026 11:44
Copy link
Copy Markdown
Collaborator

@grandizzy grandizzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense

@mattsse mattsse merged commit 26bd4ea into master May 30, 2026
19 checks passed
@mattsse mattsse deleted the mattsse/fix-tempo-scope-parser branch May 30, 2026 14:06
@github-project-automation github-project-automation Bot moved this to Done in Foundry May 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants