fix(cast): parse tempo scope signatures#14979
Merged
Merged
Conversation
b3c44bb to
16e13c0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cast sigRoot Cause
Tempo policy scopes split selector specs with a raw comma split, so full function signatures like
transfer(address,uint256)were split in the middle of their parameter list. The selector parser also hashed any string containing parentheses directly, which let malformed signatures through instead of using the normal ABI parser.Impact
cast keychainandcast wallet session createcan now accept full function signatures in--scopeentries, including signatures with comma-separated parameters, while keeping the existing shorthand and 4-byte selector forms.