[#6860] Add syntax for specifying limit when modifying number field#6861
Open
arbron wants to merge 1 commit into
Open
[#6860] Add syntax for specifying limit when modifying number field#6861arbron wants to merge 1 commit into
arbron wants to merge 1 commit into
Conversation
Adds a new syntax to the change value for `NumberField` that allows for specifying a maximum or minimum when adding or subtracting: - `system.abilities.str.value | ADD | 2 <= 20` - `flags.dnd5e.weaponCriticalThreshold | SUBTRACT | 1 >= 16` Also supports formulas within the limit: - `system.abilities.str.value | ADD | 2 <= 18 + @prof` Closes #6860
Fyorl
reviewed
Jun 9, 2026
Fyorl
left a comment
Contributor
There was a problem hiding this comment.
Given our strategy for conditional AE application, perhaps a special syntax just for number fields is unnecessary, and this would be subsumed by the conditional AE work.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a new syntax to the change value for
NumberFieldthat allows for specifying a maximum or minimum when adding or subtracting:system.abilities.str.value | ADD | 2 <= 20flags.dnd5e.weaponCriticalThreshold | SUBTRACT | 1 >= 16Also supports formulas within the limit:
system.abilities.str.value | ADD | 2 <= 18 + @profCloses #6860