[#6839] Add placed encounter members to combat

[Aioros]

While creating combatants and rolling initiative for placed members is fairly straightforward, I think the main point of contention on the feature would be how to present the option and where it is actually stored. I opted for a client-setting-backed little dialog, shown right before the actual placement of the encounter members.

Closes #6839

[arbron]

I'd probably try to avoid the dialog solution if possible, instead having a setting in the Combat Settings config for what to do when placing actors from an encounter: "Add to Combat", "Add to Combat & Roll Initiative", "Do Nothing".

If there isn't already an existing combat, then nothing would happen.

[Aioros]

The dialog was basically a personal preference coming from the way I imagined myself using the feature. I reasoned that if I had multiple encounters, and only wanted the combatants to be created for some of them, switching the setting back and forth would have felt more cumbersome, while this allows me to decide on the fly, and remember the last choice. I do trust your opinion more though, so let me prepare a different version.

If there isn't already an existing combat, then nothing would happen.

Not sure about this part, I thought creating the combat if it doesn't exist already was kind of a given. Any reason why that would be undesirable?

[Aioros]

The updated branch uses a setting as suggested (and it's quite simpler as a result). It still creates the combat if it doesn't already exist, though.

[Fyorl]

I think there's a very broad range of what people might want/expect from this feature:

• A dialog that prompts them every time they place members
• A dialog that only prompts on placement if there is a combat already active
• No dialog, but only places members in combat if there is a combat already active
• No dialog, automatically creates a combat if one is not already active (this PR)

I suspect that most people are only placing encounter members when the combat is ready to go. But equally they might be using them as a store of pre-baked encounters that they reuse when they create new scenes.

I don't have a good feel for it; I don't use encounter actors that much in my own games. Happy to go with what we have for now and iterate further.

[arbron]

@Aioros Throw up a comment on the original issue for assignment