[#4934] Use roller's spellcasting ability from check activity#7036
Open
arbron wants to merge 2 commits into
Open
[#4934] Use roller's spellcasting ability from check activity#7036arbron wants to merge 2 commits into
arbron wants to merge 2 commits into
Conversation
arbron
force-pushed
the
activity/check-spellcasting
branch
from
a90a898 to
31d0cdf
Compare
When the check ability for a Check activity is set to "Spellcasting Ability" this will now use the roller's spellcasting ability rather than that of the actor who used the activity. Adds support for `spellcasting` as an ability in all of the rolling methods on actor. Closes #4934
Adaptation of Zhell's PR in light of the new `spellcastingAbility` property on actors and support for `spellcasting` as an ability option in rolling methods. Original PR: #4883
arbron
force-pushed
the
activity/check-spellcasting
branch
from
31d0cdf to
a95b389
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the check ability for a Check activity is set to "Spellcasting Ability" this will now use the roller's spellcasting ability rather than that of the actor who used the activity.
Adds support for
spellcastingas an ability in all of the rolling methods on actor.Also allows using
spellcastingas an ability option in check and save enrichers, adapting the work from @krbz999's PR here: #4883Closes #4934