Add stricter Ruff linting (#35)

Author: william-billaud

dissect/executable/__init__.py

@@ -1,3 +1,5 @@
+from __future__ import annotations
+
 from dissect.executable.elf.elf import ELF
 from dissect.executable.pe.pe import PE
 

dissect/executable/elf/__init__.py

@@ -1,3 +1,5 @@
+from __future__ import annotations
+
 from dissect.executable.elf.elf import (
     ELF,
     Section,

dissect/executable/elf/c_elf.py

@@ -1,7 +1,12 @@
-from enum import Flag, IntEnum
+from __future__ import annotations
+
+from typing import TYPE_CHECKING
 
 from dissect.cstruct import cstruct
 
+if TYPE_CHECKING:
+    from enum import Flag, IntEnum
+
 elf_32_def = """
 typedef uint32      Elf32_Addr;
 typedef uint16      Elf32_Half;

dissect/executable/exception.py

@@ -1,3 +1,6 @@
+from __future__ import annotations
+
+
 class Error(Exception):
     """Base exception for this module."""
 

dissect/executable/pe/__init__.py

@@ -1,3 +1,5 @@
+from __future__ import annotations
+
 from dissect.executable.pe.pe import PE
 
 __all__ = [

dissect/executable/pe/directory/__init__.py

@@ -1,3 +1,5 @@
+from __future__ import annotations
+
 from dissect.executable.pe.directory.base import DataDirectory
 from dissect.executable.pe.directory.basereloc import BaseRelocationDirectory
 from dissect.executable.pe.directory.bound_import import BoundImportDirectory

dissect/executable/pe/pe.py

@@ -5,7 +5,7 @@
 from functools import cached_property
 from typing import TYPE_CHECKING, BinaryIO
 
-from dissect.util.stream import AlignedStream, BufferedStream, RangeStream
+from dissect.util.stream import AlignedStream, BufferedStream
 from dissect.util.ts import from_unix
 
 from dissect.executable.exception import InvalidSignatureError
@@ -30,6 +30,8 @@
 if TYPE_CHECKING:
     import datetime
 
+    from dissect.util.stream import RangeStream
+
 
 class PE:
     """PE file parser.

pyproject.toml

@@ -94,16 +94,33 @@ select = [
   "SLOT",
   "SIM",
   "TID",
-  "TCH",
+  "TC",
   "PTH",
   "PLC",
   "TRY",
   "FLY",
   "PERF",
   "FURB",
   "RUF",
+  "D"
 ]
-ignore = ["E203", "B904", "UP024", "ANN002", "ANN003", "ANN204", "ANN401", "SIM105", "TRY003"]
+ignore = [
+    "E203", "B904", "UP024", "ANN002", "ANN003", "ANN204", "ANN401", "SIM105", "TRY003", "PLC0415",
+    # Ignore some pydocstyle rules for now as they require a larger cleanup
+    "D1",
+    "D205",
+    "D301",
+    "D417",
+    # Seems bugged: https://github.com/astral-sh/ruff/issues/16824
+    "D402",
+]
+future-annotations = true
+
+[tool.ruff.lint.pydocstyle]
+convention = "google"
+
+[tool.ruff.lint.flake8-type-checking]
+strict = true
 
 [tool.ruff.lint.per-file-ignores]
 "tests/_docs/**" = ["INP001"]
@@ -112,6 +129,7 @@ ignore = ["E203", "B904", "UP024", "ANN002", "ANN003", "ANN204", "ANN401", "SIM1
 [tool.ruff.lint.isort]
 known-first-party = ["dissect.executable"]
 known-third-party = ["dissect"]
+required-imports = ["from __future__ import annotations"]
 
 [tool.setuptools.packages.find]
 include = ["dissect.*"]

tests/_docs/conf.py

@@ -1,3 +1,5 @@
+from __future__ import annotations
+
 project = "dissect.executable"
 
 extensions = [