Small improvement

Author: Schamper

dissect/hypervisor/disk/vdi.py

@@ -18,25 +18,32 @@
 class VDI:
     """VirtualBox Virtual Disk Image (VDI) implementation.
 
+    If provided with file-like objects, the caller is responsible for closing them.
+    When provided with paths, the VDI class will manage the file handles.
+
     Args:
         fh: File-like object or path of the VDI file.
-        parent: Optional file-like object for the parent disk (for differencing disks).
+        parent: Optional file-like object or path for the parent disk (for differencing disks).
     """
 
-    def __init__(self, fh: BinaryIO | Path, parent: BinaryIO | None = None):
+    def __init__(self, fh: BinaryIO | Path, parent: BinaryIO | Path | None = None):
         if isinstance(fh, Path):
             self.path = fh
             self.fh = self.path.open("rb")
         else:
             self.path = None
             self.fh = fh
 
-        self.parent = parent
+        if isinstance(parent, Path):
+            self.parent_path = parent
+            self.parent = self.parent_path.open("rb")
+        else:
+            self.parent_path = None
+            self.parent = parent
 
         self.fh.seek(0)
         self.preheader = c_vdi.VDIPREHEADER(self.fh)
         if self.preheader.u32Signature != VDI_IMAGE_SIGNATURE:
-            print(self.preheader)
             raise Error(
                 f"Invalid VDI signature, expected {VDI_IMAGE_SIGNATURE:#08X}, got {self.preheader.u32Signature:#08X}"
             )
@@ -95,6 +102,9 @@ def close(self) -> None:
         if self.path is not None:
             self.fh.close()
 
+        if self.parent_path is not None and self.parent is not None:
+            self.parent.close()
+
 
 class VDIStream(AlignedStream):
     def __init__(self, vdi: VDI):

tests/disk/test_vdi.py

@@ -7,7 +7,7 @@
 
 from dissect.hypervisor.disk.c_vdi import c_vdi
 from dissect.hypervisor.disk.vdi import VDI
-from tests.conftest import absolute_path
+from tests._util import absolute_path
 
 
 def mock_open_gz(self: Path, *args, **kwargs) -> BinaryIO: