Skip to content

Improve error message when running unsupported function in target-shell - #1884

Open
JSCU-CNI wants to merge 1 commit into
fox-it:mainfrom
JSCU-CNI:shell-unsupported-plugin
Open

Improve error message when running unsupported function in target-shell#1884
JSCU-CNI wants to merge 1 commit into
fox-it:mainfrom
JSCU-CNI:shell-unsupported-plugin

Conversation

@JSCU-CNI

@JSCU-CNI JSCU-CNI commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

Removes the enormous stack trace target-shell shows when attempting to run a plugin that is not supported on the current target.

Also slightly modifies the UnsupportedPluginError message get_function throws to improve readability.

WIN-EXAMPLE:/$ msn
Unsupported function `msn` for this target with OS Windows
WIN-EXAMPLE:/$

@Schamper Schamper left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a unit test? And perhaps just use .os for the OS name?

@JSCU-CNI
JSCU-CNI force-pushed the shell-unsupported-plugin branch from f9120a6 to 0262d70 Compare July 20, 2026 14:28
@JSCU-CNI
JSCU-CNI requested a review from Schamper July 20, 2026 14:28
@codecov

codecov Bot commented Jul 20, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.08%. Comparing base (bbd7fae) to head (0262d70).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1884   +/-   ##
=======================================
  Coverage   81.08%   81.08%           
=======================================
  Files         409      409           
  Lines       36706    36710    +4     
=======================================
+ Hits        29763    29767    +4     
  Misses       6943     6943           
Flag Coverage Δ
unittests 81.08% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@codspeed-hq

codspeed-hq Bot commented Jul 20, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 32 untouched benchmarks


Comparing JSCU-CNI:shell-unsupported-plugin (0262d70) with main (bbd7fae)

Open in CodSpeed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants