Improve error message when running unsupported function in target-shell - #1884
Open
JSCU-CNI wants to merge 1 commit into
Open
Improve error message when running unsupported function in target-shell#1884JSCU-CNI wants to merge 1 commit into
JSCU-CNI wants to merge 1 commit into
Conversation
Schamper
requested changes
Jul 20, 2026
Schamper
left a comment
Member
There was a problem hiding this comment.
Can you add a unit test? And perhaps just use .os for the OS name?
JSCU-CNI
force-pushed
the
shell-unsupported-plugin
branch
from
July 20, 2026 14:28
f9120a6 to
0262d70
Compare
Schamper
approved these changes
Jul 20, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1884 +/- ##
=======================================
Coverage 81.08% 81.08%
=======================================
Files 409 409
Lines 36706 36710 +4
=======================================
+ Hits 29763 29767 +4
Misses 6943 6943
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the enormous stack trace
target-shellshows when attempting to run a plugin that is not supported on the current target.Also slightly modifies the
UnsupportedPluginErrormessageget_functionthrows to improve readability.