Skip to content

fix: Use correct hex constant for flag bit in VariableBitsetSerializer #596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
elementbound merged 3 commits into from
May 11, 2026
Merged

fix: Use correct hex constant for flag bit in VariableBitsetSerializer #596

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4323598
fix: Use correct hex constant for flag bit in VariableBitsetSerializer
domsl May 9, 2026
49e5416
add test
elementbound May 11, 2026
864a642
bv
elementbound May 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion addons/netfox.extras/plugin.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,5 +3,5 @@
name="netfox.extras"
description="Game-specific utilities for Netfox"
author="Tamas Galffy and contributors"
version="1.43.3"
version="1.43.4"
script="netfox-extras.gd"
2 changes: 1 addition & 1 deletion addons/netfox.internals/plugin.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,5 +3,5 @@
name="netfox.internals"
description="Shared internals for netfox addons"
author="Tamas Galffy and contributors"
version="1.43.3"
version="1.43.4"
script="plugin.gd"
2 changes: 1 addition & 1 deletion addons/netfox.noray/plugin.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,5 +3,5 @@
name="netfox.noray"
description="Bulletproof your connectivity with noray integration for netfox"
author="Tamas Galffy and contributors"
version="1.43.3"
version="1.43.4"
script="netfox-noray.gd"
2 changes: 1 addition & 1 deletion addons/netfox/plugin.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,5 +3,5 @@
name="netfox"
description="Shared internals for netfox addons"
author="Tamas Galffy and contributors"
version="1.43.3"
version="1.43.4"
script="netfox.gd"
2 changes: 1 addition & 1 deletion addons/netfox/schemas/network-schemas.gd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -579,7 +579,7 @@ class _VariableBitsetSerializer extends NetworkSchemaSerializer:
if bitset.bit_count() > i + 6 and bitset.get_bit(i + 6): byte |= 0x40

# Set highest bit if there's more bytes to read
if bitset.bit_count() > i + 7: byte |= 80
if bitset.bit_count() > i + 7: byte |= 0x80

b.put_u8(byte)

Expand Down
3 changes: 2 additions & 1 deletion test/netfox/schemas/network-schemas.test.gd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,8 @@ func suite() -> void:
["netref name", NetworkSchemas._netref(), _NetworkIdentityReference.of_full_name("path"), 9],

# Private
["varbits", NetworkSchemas._varbits(), _Bitset.of_bools([0, 1, 0, 1, 1, 0, 1]), 1]
["varbits", NetworkSchemas._varbits(), _Bitset.of_bools([0, 1, 0, 1, 1, 0, 1]), 1],
["varbits", NetworkSchemas._varbits(), _Bitset.of_bools([0, 1, 0, 1, 1, 0, 1, 0, 1, 1, 1, 0, 0, 1]), 2],
]

for case in cases:
Expand Down
Loading