[DO NOT MERGE] experiment: rollback effects instead of RewindableAction#601
Closed
aromancev wants to merge 1 commit into
Closed
[DO NOT MERGE] experiment: rollback effects instead of RewindableAction#601aromancev wants to merge 1 commit into
aromancev wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An experiment to see if it's possible to implement rollbackable effects without using
RewindableActionor adding any additional network synchronization primitives.Idea: gameplay state drives the weapon, and effects are recorded separately so resimulation can keep or revert them. This is conceptually the same as https://react.dev/reference/react/useEffect.
Straightforward apply and revert of events. Zero network cost. Low complexity.
The main change is in examples/rollback-fps/scripts/player-weapon.gd.