fix(infra): define Configuration type before its methods (#2695)

Moves the BillingMode, UsesOrgBilling and BillingServiceURL methods below
the Configuration struct definition to satisfy gocritic typeDefFirst. The
violation is latent on main: normal PR lint hides it via only-new-issues,
but the merge queue cannot read the base ref to diff against and reports
all issues, which blocks every PR from merging.

Author: mekilis

config/config.go

@@ -36,36 +36,6 @@ const (
 // OSS or self-hosted instance has not configured an explicit billing URL.
 const DefaultOverwatchHost = "https://overwatch.getconvoy.cloud"
 
-func (c Configuration) BillingMode(instanceLicenseKey string) BillingMode {
-	if strings.TrimSpace(c.Billing.APIKey) != "" {
-		return BillingModeCloud
-	}
-	if strings.TrimSpace(instanceLicenseKey) != "" {
-		return BillingModeLicensedSelfHosted
-	}
-	return BillingModeOSS
-}
-
-func (c Configuration) UsesOrgBilling() bool {
-	return c.BillingMode("") == BillingModeCloud
-}
-
-// BillingServiceURL returns the billing service base URL to use. OSS and
-// self-hosted instances (no billing API key) default to prod Overwatch so the
-// plan catalog, guest checkout, and license management work without operator
-// config, mirroring the SSO/license service defaults. Cloud (API key set) keeps
-// requiring an explicit URL: an empty URL there is a misconfiguration that
-// Billing.Validate already fails closed on, so this never invents a cloud host.
-func (c Configuration) BillingServiceURL() string {
-	if url := strings.TrimSpace(c.Billing.URL); url != "" {
-		return url
-	}
-	if strings.TrimSpace(c.Billing.APIKey) == "" {
-		return DefaultOverwatchHost
-	}
-	return ""
-}
-
 var cfgSingleton atomic.Value
 
 var DefaultConfiguration = Configuration{
@@ -570,6 +540,36 @@ type Configuration struct {
 	Billing             BillingConfiguration         `json:"billing"`
 }
 
+func (c Configuration) BillingMode(instanceLicenseKey string) BillingMode {
+	if strings.TrimSpace(c.Billing.APIKey) != "" {
+		return BillingModeCloud
+	}
+	if strings.TrimSpace(instanceLicenseKey) != "" {
+		return BillingModeLicensedSelfHosted
+	}
+	return BillingModeOSS
+}
+
+func (c Configuration) UsesOrgBilling() bool {
+	return c.BillingMode("") == BillingModeCloud
+}
+
+// BillingServiceURL returns the billing service base URL to use. OSS and
+// self-hosted instances (no billing API key) default to prod Overwatch so the
+// plan catalog, guest checkout, and license management work without operator
+// config, mirroring the SSO/license service defaults. Cloud (API key set) keeps
+// requiring an explicit URL: an empty URL there is a misconfiguration that
+// Billing.Validate already fails closed on, so this never invents a cloud host.
+func (c Configuration) BillingServiceURL() string {
+	if url := strings.TrimSpace(c.Billing.URL); url != "" {
+		return url
+	}
+	if strings.TrimSpace(c.Billing.APIKey) == "" {
+		return DefaultOverwatchHost
+	}
+	return ""
+}
+
 type DispatcherConfiguration struct {
 	InsecureSkipVerify bool     `json:"insecure_skip_verify" envconfig:"CONVOY_DISPATCHER_INSECURE_SKIP_VERIFY"`
 	AllowList          []string `json:"allow_list" envconfig:"CONVOY_DISPATCHER_ALLOW_LIST"`