fix(build): refactor docker install script#2711
Open
motunrayokoyejo wants to merge 3 commits into
Open
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit ef8f00c. Configure here.
| local selected | ||
| selected="$(find_available_port "$fallback_start")" || return 1 | ||
| warn "${label} port ${requested} is unavailable. Using ${selected} instead." | ||
| printf "%s" "$selected" |
There was a problem hiding this comment.
Unknown port eighty forced fallback
Medium Severity
When the default HTTP port cannot be probed (Python bind returns permission denied), resolve_host_port treats it as unavailable and picks a fallback such as 8080. Docker can still publish port 80 without that bind test, so installs on Linux without lsof often get the wrong public URL versus the previous installer.
Reviewed by Cursor Bugbot for commit ef8f00c. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Added/expanded install-local.sh to provide a smoother first-time local setup flow.
Installer now validates prerequisites (git, curl, docker, docker compose, Docker daemon).
Added robust repo setup handling
Note
Low Risk
Changes are limited to the local install script and generated compose artifacts; no application runtime or auth paths are modified.
Overview
Local Docker install no longer hard-fails when default ports are busy.
install-local.shpicks HTTP, Postgres, and PgBouncer host ports (env overridesCONVOY_HTTP_PORT, etc., with fallbacks from 8080/5434/6433), writesconfigs/local/docker-compose.install.generated.ymlfrom the base compose file, and runsdocker composeagainst that file only.Convoy’s public URL stays aligned with the chosen HTTP port by patching the first
"host"field inconfigs/local/convoy.json, and health checks / “open this URL” output use the sameSELECTED_HOST_URL..gitignore now excludes the generated compose file and a legacy override path; the installer deletes the stale override file on upgrade.
Reviewed by Cursor Bugbot for commit ef8f00c. Bugbot is set up for automated code reviews on this repo. Configure here.