fix(agent): use smtp.reply_to for CONVOY_SMTP_REPLY_TO (was smtp.from)#90
Merged
Conversation
olamilekan000
enabled auto-merge (squash)
July 14, 2026 19:50
mekilis
approved these changes
Jul 14, 2026
mekilis
left a comment
mekilis
left a comment
Contributor
There was a problem hiding this comment.
Looks good. Matches the chart bug: CONVOY_SMTP_REPLY_TO was copying smtp.from and ignoring smtp.reply_to. Deployment and rollout are both fixed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The agent deployment and rollout templates set CONVOY_SMTP_REPLY_TO from
.Values.env.smtp.from, so the reply-to address always matched the from
address and the existing smtp.reply_to value was silently ignored. The app
(config.go) treats From and ReplyTo as independent fields. Point the env var
at .Values.env.smtp.reply_to in both charts/agent templates.
Note
Low Risk
Two-line Helm env mapping fix with no auth or data-path changes; behavior only shifts when reply_to differs from from.
Overview
Fixes a wiring bug in the agent Helm chart so SMTP reply-to matches chart values and app config.
When SMTP is enabled,
CONVOY_SMTP_REPLY_TOin bothdeployment.yamlandrollout.yamlnow comes from.Values.env.smtp.reply_toinstead of.Values.env.smtp.from. Previously reply-to always mirrored the from address andsmtp.reply_tohad no effect on deployed pods.Reviewed by Cursor Bugbot for commit 883d55e. Bugbot is set up for automated code reviews on this repo. Configure here.