Skip to content

Fix require cycle in TransitionItem.js#214

Open
Jonathan0wh wants to merge 1 commit intofram-x:developfrom
Jonathan0wh:Fix-175/RequireCycle
Open

Fix require cycle in TransitionItem.js#214
Jonathan0wh wants to merge 1 commit intofram-x:developfrom
Jonathan0wh:Fix-175/RequireCycle

Conversation

@Jonathan0wh
Copy link
Copy Markdown

Minor fix for #175. This should fix the require cycle warning below when installing the package, by bypassing Utils/index.js:

require.js:114 Require cycle: 
node_modules/react-navigation-fluid-transitions/TransitionItem.js 
-> node_modules/react-navigation-fluid-transitions/Utils/index.js 
-> node_modules/react-navigation-fluid-transitions/Utils/getResolvedMetrics.js 
-> node_modules/react-navigation-fluid-transitions/TransitionItem.js

Require cycles are allowed, but can result in uninitialized values. 
Consider refactoring to remove the need for a cycle.

@kaueDM
Copy link
Copy Markdown

kaueDM commented Oct 10, 2019

Can someone merge it? Is really annoying this warning in the console.

@chrfalch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants