Skip to content

Commit 8dcb378

Browse files
AliKdhim87AliKdhim87
committed
chore: make KCM version configurable via environment variable
1 parent e3436d4 commit 8dcb378

6 files changed

Lines changed: 20 additions & 2 deletions

File tree

‎.envrc.json‎

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -365,6 +365,14 @@
365365
"valueType": "url",
366366
"example": "https://viewer.kcmg.nl/",
367367
"developmentDefault": "https://viewer.kcmg.nl/"
368+
},
369+
{
370+
"name": "KCM_SURVEY_VERSION",
371+
"description": "Version of the KCM Survey widget to use (e.g., 'latest' or specific version number).",
372+
"required": false,
373+
"valueType": "number",
374+
"developmentDefault": "",
375+
"example": "v4.49"
368376
}
369377
]
370378
}

‎ENVIRONMENT_VARIABLES.md‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,7 @@
2929
| `KCM_SURVEY_ID` | string | | | Survey ID for the KCM Survey widget, used to identify which survey to display. | `add-kcm-survey-id` | `` |
3030
| `KCM_SURVEY_STYLESHEETS_LINK` | url | | | URL for the custom stylesheet for the KCM Survey widget (e.g., https://www.utrecht.nl/fileadmin/kcm-radio.css). | `https://www.utrecht.nl` | `https://www.utrecht.nl` |
3131
| `KCM_SURVEY_URL` | url | | | Base URL for the KCM Survey service where the survey widget is hosted. | `https://viewer.kcmg.nl/` | `https://viewer.kcmg.nl/` |
32+
| `KCM_SURVEY_VERSION` | string | | | Version of the KCM Survey widget to use (e.g., 'latest' or specific version number). | `` | `` |
3233
| `MATOMO_HOST` | url | | | URL where the Matomo is hosted | `https://example.com` | `https://example.com` |
3334
| `MATOMO_SITE_ID` | string | | | Website ID for the Matomo tracker API. See: https://matomo.org/faq/general/faq_19212/ | `36D0C594-E017-485B-B032-C436` | `36D0C594-E017-485B-B032-C436EC876E5B` |
3435
| `NODE_ENV` | string | ✅ | | Enable production mode for Node.js. See: https://nodejs.org/en/learn/getting-started/nodejs-the-difference-between-development-and-production | `` | `production` |

‎apps/pdc-frontend/src/components/KCMSurvey/index.tsx‎

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,15 +18,21 @@ export const KCMSurvey = ({ nonce }: KCMSurveyProps) => {
1818
const kcmSurveyURL = buildURL({
1919
env: process.env,
2020
key: 'KCM_SURVEY_URL',
21-
segments: ['surveyembedding', 'v4.48', 'kcm-survey.js'],
21+
// the current API behaver is when you don't provide a version it pulls the latest version
22+
segments: ['surveyembedding', process.env.KCM_SURVEY_VERSION ?? '', 'kcm-survey.js'].filter(Boolean),
2223
});
2324
const kcmSurveyStylesheetLink = buildURL({
2425
env: process.env,
2526
key: 'KCM_SURVEY_STYLESHEETS_LINK',
2627
segments: ['fileadmin', 'kcm-radio.css'],
2728
});
2829

29-
if (!process.env.KCM_SURVEY_URL || !process.env.KCM_SURVEY_ID || !process.env.KCM_SURVEY_API_KEY) {
30+
if (
31+
!process.env.KCM_SURVEY_URL ||
32+
!process.env.KCM_SURVEY_ID ||
33+
!process.env.KCM_SURVEY_API_KEY ||
34+
!process.env.KCM_SURVEY_VERSION
35+
) {
3036
return null;
3137
}
3238

‎apps/strapi.frameless.io/docs/developers/ENVIRONMENT_VARIABLES.md‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,7 @@
2929
| `KCM_SURVEY_ID` | string | | | Survey ID for the KCM Survey widget, used to identify which survey to display. | `add-kcm-survey-id` | `` |
3030
| `KCM_SURVEY_STYLESHEETS_LINK` | url | | | URL for the custom stylesheet for the KCM Survey widget (e.g., https://www.utrecht.nl/fileadmin/kcm-radio.css). | `https://www.utrecht.nl` | `https://www.utrecht.nl` |
3131
| `KCM_SURVEY_URL` | url | | | Base URL for the KCM Survey service where the survey widget is hosted. | `https://viewer.kcmg.nl/` | `https://viewer.kcmg.nl/` |
32+
| `KCM_SURVEY_VERSION` | string | | | Version of the KCM Survey widget to use (e.g., 'latest' or specific version number). | `` | `` |
3233
| `MATOMO_HOST` | url | | | URL where the Matomo is hosted | `https://example.com` | `https://example.com` |
3334
| `MATOMO_SITE_ID` | string | | | Website ID for the Matomo tracker API. See: https://matomo.org/faq/general/faq_19212/ | `36D0C594-E017-485B-B032-C436` | `36D0C594-E017-485B-B032-C436EC876E5B` |
3435
| `NODE_ENV` | string | ✅ | | Enable production mode for Node.js. See: https://nodejs.org/en/learn/getting-started/nodejs-the-difference-between-development-and-production | `` | `production` |

‎docker-compose.pdc.dev.yml‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -69,6 +69,7 @@ services:
6969
KCM_SURVEY_ID: ${KCM_SURVEY_ID}
7070
KCM_SURVEY_STYLESHEETS_LINK: ${KCM_SURVEY_STYLESHEETS_LINK}
7171
KCM_SURVEY_URL: ${KCM_SURVEY_URL}
72+
KCM_SURVEY_VERSION: ${KCM_SURVEY_VERSION}
7273
MATOMO_HOST: ${MATOMO_HOST}
7374
MATOMO_SITE_ID: ${MATOMO_SITE_ID}
7475
OGONE_PAYMENT_SERVICE_URL: ${OGONE_PAYMENT_SERVICE_URL}

‎docker-compose.pdc.prod.yml‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -61,6 +61,7 @@ services:
6161
KCM_SURVEY_ID: ${KCM_SURVEY_ID}
6262
KCM_SURVEY_STYLESHEETS_LINK: ${KCM_SURVEY_STYLESHEETS_LINK}
6363
KCM_SURVEY_URL: ${KCM_SURVEY_URL}
64+
KCM_SURVEY_VERSION: ${KCM_SURVEY_VERSION}
6465
MATOMO_HOST: ${MATOMO_HOST}
6566
MATOMO_SITE_ID: ${MATOMO_SITE_ID}
6667
OGONE_PAYMENT_SERVICE_URL: ${OGONE_PAYMENT_SERVICE_URL}

0 commit comments

Comments
 (0)