Skip to content

Commit caae104

Browse files
authored
Merge pull request #628 from framer/field-button-truncation
Truncate button text in Notion and Airtable
2 parents 079ec4f + 6d37f65 commit caae104

4 files changed

Lines changed: 14 additions & 2 deletions

File tree

plugins/airtable/src/App.css

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -130,6 +130,11 @@ select:not(:disabled) {
130130
gap: 8px;
131131
}
132132

133+
.mapping .source-field span {
134+
overflow: hidden;
135+
text-overflow: ellipsis;
136+
}
137+
133138
.mapping .source-field[aria-disabled="true"] {
134139
opacity: 0.5;
135140
}

plugins/airtable/src/FieldMapping.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,7 @@ import { isCollectionReference } from "./utils"
88

99
function ChevronIcon() {
1010
return (
11-
<svg xmlns="http://www.w3.org/2000/svg" width="8" height="16">
12-
<title>Chevron</title>
11+
<svg xmlns="http://www.w3.org/2000/svg" width="8" height="16" aria-hidden="true">
1312
<path
1413
d="M 3 11 L 6 8 L 3 5"
1514
fill="transparent"
@@ -75,6 +74,7 @@ const FieldMappingRow = memo(
7574
onClick={disabled ? undefined : () => onToggleIgnored?.(field.id)}
7675
tabIndex={0}
7776
disabled={disabled || unsupported || missingCollection}
77+
title={originalFieldName ?? field.id}
7878
>
7979
<input type="checkbox" checked={!isIgnored} tabIndex={-1} readOnly disabled={disabled} />
8080
<span>{originalFieldName ?? field.id}</span>

plugins/notion/src/App.css

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -166,6 +166,11 @@ p a {
166166
gap: 8px;
167167
}
168168

169+
.mapping .source-field span {
170+
overflow: hidden;
171+
text-overflow: ellipsis;
172+
}
173+
169174
.mapping .source-field.unsupported {
170175
pointer-events: none;
171176
}

plugins/notion/src/FieldMapping.tsx

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -79,6 +79,7 @@ function FieldMappingRow({
7979
onToggleIgnored(id)
8080
}}
8181
tabIndex={0}
82+
title={originalName}
8283
>
8384
<input type="checkbox" checked={!disabled} tabIndex={-1} readOnly />
8485
<span>{originalName}</span>
@@ -88,6 +89,7 @@ function FieldMappingRow({
8889
width="8"
8990
height="8"
9091
fill="none"
92+
aria-hidden="true"
9193
style={{ opacity: disabled ? 0.5 : 1 }}
9294
>
9395
<path

0 commit comments

Comments
 (0)