Skip to content

cleanup: use framer-spinner class in Unsplash#621

Merged
madebyisaacr merged 1 commit intomainfrom
unsplash-spinner
Apr 30, 2026
Merged

cleanup: use framer-spinner class in Unsplash#621
madebyisaacr merged 1 commit intomainfrom
unsplash-spinner

Conversation

@madebyisaacr
Copy link
Copy Markdown
Collaborator

@madebyisaacr madebyisaacr commented Apr 8, 2026

Description

This pull request replaces the spinner component in Unsplash with the built-in framer-spinner class. This change also makes the image loading spinner smaller to match other spinners in Framer, but if there's a reason to use the larger spinner size, that can be changed.

Changelog

  • Updated loading spinner style.

Testing

  • Insert an image and look at the spinner. Verify that the spinner is white in both light and dark themes.
  • Click the random image button and look at the spinner

@github-actions github-actions Bot added the Auto submit to Marketplace on merge Submits the plugin to the marketplace after merging label Apr 8, 2026
@madebyisaacr madebyisaacr requested a review from huntercaron April 8, 2026 13:09
@github-actions
Copy link
Copy Markdown

This PR has been automatically marked as stale because it has not had any activity in the last 7 days. It will be closed if no further activity occurs in the next 7 days.

@github-actions
Copy link
Copy Markdown

This PR has been automatically marked as stale because it has not had any activity in the last 7 days. It will be closed if no further activity occurs in the next 7 days.

@github-actions github-actions Bot added the stale label Apr 24, 2026
@madebyisaacr madebyisaacr changed the title Unsplash: use framer-spinner class cleanup: use framer-spinner class in Unsplash Apr 29, 2026
Copy link
Copy Markdown
Collaborator

@huntercaron huntercaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@madebyisaacr madebyisaacr enabled auto-merge April 30, 2026 16:39
@madebyisaacr madebyisaacr added this pull request to the merge queue Apr 30, 2026
Merged via the queue into main with commit 7c43b7f Apr 30, 2026
10 of 11 checks passed
@madebyisaacr madebyisaacr deleted the unsplash-spinner branch April 30, 2026 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Auto submit to Marketplace on merge Submits the plugin to the marketplace after merging

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants