Remove aveta dependency from Google Search Console to avoid crasher#640
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the aveta dependency from the Google Search Console plugin (to address Vite 8 production bundling issues) and replaces it with an in-repo stat formatting helper.
Changes:
- Removed
avetafromplugins/google-search-consoledependencies (and cleaned upyarn.lock). - Updated the Performance screen to use a new local
formatStathelper for click/impression totals. - Added unit tests for
formatStatand added acheck-vitestscript for the plugin.
Reviewed changes
Copilot reviewed 4 out of 12 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| yarn.lock | Removes aveta and its transitive deps from the lockfile. |
| plugins/google-search-console/package.json | Drops aveta dependency; adds check-vitest script. |
| plugins/google-search-console/src/screens/Performance.tsx | Replaces aveta(totalX) with formatStat(totalX) for displayed totals. |
| plugins/google-search-console/src/formatStat.ts | Adds local stat-abbreviation formatter (K/M/B/…). |
| plugins/google-search-console/src/formatStat.test.ts | Adds Vitest coverage for formatting and edge cases. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
5cb6724 to
a67df69
Compare
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
a67df69 to
67a4ad7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This was causing some issues with Vite 8 production bundling, and should never have been a dependency in the first place
Changelog
Testing