test: update existing tests for meeting details and goal update changes

Update mock expectations in meeting tests to match the new direct API
call pattern (GET L10/{id} instead of list-then-filter). Update goal
tests to reflect that accountable_user is no longer auto-populated.
Update bulk operation tests for new meeting details behavior.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Author: franccesco

tests/test_async_goals.py

@@ -202,7 +202,6 @@ async def test_update(
         mock_async_client.put.assert_called_once_with(
             "rocks/123",
             json={
-                "accountableUserId": 1,
                 "title": "Updated Goal",
                 "completion": "OnTrack",
             },

tests/test_async_meetings.py

@@ -332,12 +332,30 @@ async def test_get_many_all_successful(
         self, async_client: AsyncClient, mock_async_client: AsyncMock
     ) -> None:
         """Test bulk retrieval where all meetings are retrieved successfully."""
-        # Mock meeting list response for details method
-        mock_meetings_list = [
-            {"Id": 100, "Type": "L10", "Key": "L10-100", "Name": "Weekly Standup"},
-            {"Id": 101, "Type": "L10", "Key": "L10-101", "Name": "Sprint Planning"},
-            {"Id": 102, "Type": "L10", "Key": "L10-102", "Name": "Retrospective"},
-        ]
+        # Mock direct L10/{id} responses and sub-resource responses
+        direct_responses = {
+            100: {
+                "Id": 100,
+                "Basics": {"Name": "Weekly Standup"},
+                "CreateTime": None,
+                "StartDateUtc": None,
+                "OrganizationId": None,
+            },
+            101: {
+                "Id": 101,
+                "Basics": {"Name": "Sprint Planning"},
+                "CreateTime": None,
+                "StartDateUtc": None,
+                "OrganizationId": None,
+            },
+            102: {
+                "Id": 102,
+                "Basics": {"Name": "Retrospective"},
+                "CreateTime": None,
+                "StartDateUtc": None,
+                "OrganizationId": None,
+            },
+        }
 
         # Mock attendees responses
         attendees_responses = {
@@ -373,17 +391,17 @@ async def test_get_many_all_successful(
         def get_side_effect(url, **_kwargs):
             mock_response = MagicMock()
 
-            if url.endswith("/list"):
-                mock_response.json.return_value = mock_meetings_list
-            elif "/attendees" in url:
-                # Extract meeting ID from URL
+            if "/attendees" in url:
                 meeting_id = int(url.split("/")[1])
                 mock_response.json.return_value = attendees_responses.get(
                     meeting_id, []
                 )
-            else:
-                # For issues, todos, metrics
+            elif "/issues" in url or "/todos" in url or "/measurables" in url:
                 mock_response.json.return_value = []
+            else:
+                # Direct L10/{id} endpoint
+                meeting_id = int(url.split("/")[1])
+                mock_response.json.return_value = direct_responses.get(meeting_id, {})
 
             mock_response.raise_for_status = MagicMock()
             return mock_response
@@ -409,25 +427,37 @@ def get_side_effect(url, **_kwargs):
         assert len(result.successful[2].attendees) == 1
 
         # Verify API calls - 5 calls per meeting
-        # (list, attendees, issues, todos, metrics)
+        # (direct, attendees, issues, todos, metrics)
         assert mock_async_client.get.call_count == 15
 
     @pytest.mark.asyncio
     async def test_get_many_partial_failure(
         self, async_client: AsyncClient, mock_async_client: AsyncMock
     ) -> None:
         """Test bulk retrieval where some meetings fail."""
-        # Mock meeting list response - contains meeting 200 but not 999 or 500
-        mock_meetings_list = [
-            {"Id": 200, "Type": "L10", "Key": "L10-200", "Name": "Success Meeting"},
-        ]
+        from httpx import HTTPStatusError, Request, Response
 
         # Create side effect function that returns appropriate response based on URL
         def get_side_effect(url, **_kwargs):
             mock_response = MagicMock()
 
-            if url.endswith("/list"):
-                mock_response.json.return_value = mock_meetings_list
+            # Direct endpoint for meeting 200
+            if url == "L10/200":
+                mock_response.json.return_value = {
+                    "Id": 200,
+                    "Basics": {"Name": "Success Meeting"},
+                    "CreateTime": None,
+                    "StartDateUtc": None,
+                    "OrganizationId": None,
+                }
+                mock_response.raise_for_status = MagicMock()
+            elif url in ("L10/999", "L10/500"):
+                # Simulate 404 for non-existent meetings
+                mock_response.raise_for_status.side_effect = HTTPStatusError(
+                    "Not Found",
+                    request=Request("GET", url),
+                    response=Response(404),
+                )
             elif "/200/attendees" in url:
                 mock_response.json.return_value = [
                     {
@@ -436,11 +466,11 @@ def get_side_effect(url, **_kwargs):
                         "ImageUrl": "https://example.com/img1.jpg",
                     }
                 ]
+                mock_response.raise_for_status = MagicMock()
             else:
-                # For issues, todos, metrics
                 mock_response.json.return_value = []
+                mock_response.raise_for_status = MagicMock()
 
-            mock_response.raise_for_status = MagicMock()
             return mock_response
 
         mock_async_client.get.side_effect = get_side_effect
@@ -458,11 +488,9 @@ def get_side_effect(url, **_kwargs):
         # Check failed items
         assert result.failed[0].index == 1
         assert result.failed[0].input_data["meeting_id"] == 999
-        assert "not found" in result.failed[0].error.lower()
 
         assert result.failed[1].index == 2
         assert result.failed[1].input_data["meeting_id"] == 500
-        assert "not found" in result.failed[1].error.lower()
 
     @pytest.mark.asyncio
     async def test_get_many_empty_list(
@@ -507,29 +535,26 @@ async def delayed_get(*args, **_kwargs):
             # Extract the URL from args (first positional argument)
             url = args[0] if args else ""
 
-            if url.endswith("/list"):
-                # Return list of all meetings
-                mock_response.json.return_value = [
-                    {
-                        "Id": i + 400,
-                        "Type": "L10",
-                        "Key": f"L10-{i + 400}",
-                        "Name": f"Meeting {i}",
-                    }
-                    for i in range(5)
-                ]
-            elif "/attendees" in url:
-                # Return attendees for any meeting
+            if "/attendees" in url:
                 mock_response.json.return_value = [
                     {
                         "Id": 456,
                         "Name": "John Doe",
                         "ImageUrl": "https://example.com/img.jpg",
                     }
                 ]
-            else:
-                # For issues, todos, metrics
+            elif "/issues" in url or "/todos" in url or "/measurables" in url:
                 mock_response.json.return_value = []
+            else:
+                # Direct L10/{id} endpoint
+                meeting_id = int(url.split("/")[1])
+                mock_response.json.return_value = {
+                    "Id": meeting_id,
+                    "Basics": {"Name": f"Meeting {meeting_id - 400}"},
+                    "CreateTime": None,
+                    "StartDateUtc": None,
+                    "OrganizationId": None,
+                }
 
             mock_response.raise_for_status = MagicMock()
             return mock_response
@@ -551,7 +576,7 @@ async def delayed_get(*args, **_kwargs):
 
         # Verify concurrent execution
         # With max_concurrent=3 and 5 meetings:
-        # Each meeting makes 5 API calls (list, attendees, issues, todos, metrics)
+        # Each meeting makes 5 API calls (direct, attendees, issues, todos, metrics)
         # Each call has 0.1s delay, so each meeting takes ~0.5s
         # With concurrency of 3, we should see significant speedup vs sequential
         # Sequential would take 5 * 0.5 = 2.5s

tests/test_async_meetings_extra.py

@@ -6,7 +6,6 @@
 import pytest_asyncio
 
 from bloomy import AsyncClient
-from bloomy.exceptions import APIError
 from bloomy.models import Issue, Todo
 
 
@@ -192,27 +191,18 @@ async def test_todos_include_closed(
     async def test_details_meeting_not_found(
         self, async_client: AsyncClient, mock_async_client: AsyncMock
     ) -> None:
-        """Test details when meeting is not found."""
-        # Mock user response
-        mock_user_response = MagicMock()
-        mock_user_response.json.return_value = {"Id": 456}
-        mock_user_response.raise_for_status = MagicMock()
-
-        # Mock empty meetings list
-        mock_meetings_response = MagicMock()
-        mock_meetings_response.json.return_value = []
-        mock_meetings_response.raise_for_status = MagicMock()
-
-        def get_side_effect(url: str) -> MagicMock:
-            if url == "users/mine":
-                return mock_user_response
-            elif url == "L10/456/list":
-                return mock_meetings_response
-            else:
-                raise ValueError(f"Unexpected URL: {url}")
-
-        mock_async_client.get.side_effect = get_side_effect
-
-        # Call the method and expect error
-        with pytest.raises(APIError, match="Meeting with ID 999 not found"):
+        """Test details when meeting is not found (404 from direct endpoint)."""
+        from httpx import HTTPStatusError, Request, Response
+
+        # Mock the direct L10/{id} endpoint to return 404
+        mock_response = MagicMock()
+        mock_response.raise_for_status.side_effect = HTTPStatusError(
+            "Not Found",
+            request=Request("GET", "L10/999"),
+            response=Response(404),
+        )
+        mock_async_client.get.return_value = mock_response
+
+        # Call the method and expect HTTP error
+        with pytest.raises(HTTPStatusError):
             await async_client.meeting.details(999)