Skip to content

Commit a5e35c2

Browse files
franccescoclaude
andcommitted
fix(ci): skip integration tests in CI and fix pyright type error
Exclude integration tests from CI runs with -m "not integration" since they require BG_API_KEY. Fix pyright type error in meetings transform by extracting Owner dict to a typed local variable. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1 parent ec4fe5b commit a5e35c2

2 files changed

Lines changed: 19 additions & 16 deletions

File tree

.github/workflows/tests.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ jobs:
3939
run: uv sync --all-extras
4040

4141
- name: Run tests with coverage
42-
run: uv run pytest --cov=bloomy --cov-report=term-missing --cov-report=xml
42+
run: uv run pytest -m "not integration" --cov=bloomy --cov-report=term-missing --cov-report=xml
4343

4444
- name: Upload coverage report
4545
if: matrix.python-version == '3.12'

src/bloomy/operations/mixins/meetings_transform.py

Lines changed: 18 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -101,19 +101,22 @@ def _transform_meeting_issues(
101101
A list of Issue models.
102102
103103
"""
104-
return [
105-
Issue(
106-
Id=issue["Id"],
107-
Name=issue["Name"],
108-
DetailsUrl=issue["DetailsUrl"],
109-
CreateDate=issue["CreateTime"],
110-
ClosedDate=issue["CloseTime"],
111-
CompletionDate=issue.get("CompleteTime"),
112-
OwnerId=(issue.get("Owner") or {}).get("Id", 0),
113-
OwnerName=(issue.get("Owner") or {}).get("Name", ""),
114-
OwnerImageUrl=(issue.get("Owner") or {}).get("ImageUrl", ""),
115-
MeetingId=meeting_id,
116-
MeetingName=issue["Origin"],
104+
issues: list[Issue] = []
105+
for issue in data:
106+
owner: dict[str, Any] = issue.get("Owner") or {}
107+
issues.append(
108+
Issue(
109+
Id=issue["Id"],
110+
Name=issue["Name"],
111+
DetailsUrl=issue["DetailsUrl"],
112+
CreateDate=issue["CreateTime"],
113+
ClosedDate=issue["CloseTime"],
114+
CompletionDate=issue.get("CompleteTime"),
115+
OwnerId=owner.get("Id", 0),
116+
OwnerName=owner.get("Name", ""),
117+
OwnerImageUrl=owner.get("ImageUrl", ""),
118+
MeetingId=meeting_id,
119+
MeetingName=issue["Origin"],
120+
)
117121
)
118-
for issue in data
119-
]
122+
return issues

0 commit comments

Comments
 (0)