Skip to content

Commit d2575bf

Browse files
authored
Merge pull request #27 from franccesco/dream/2026-07-23.1/finding-007
dream: use httpx params for todo complete
2 parents 9e1c321 + 933c6f9 commit d2575bf

4 files changed

Lines changed: 12 additions & 4 deletions

File tree

src/bloomy/operations/async_/todos.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -145,7 +145,9 @@ async def complete(self, todo_id: int) -> Todo:
145145
```
146146
147147
"""
148-
response = await self._client.post(f"todo/{todo_id}/complete?status=true")
148+
response = await self._client.post(
149+
f"todo/{todo_id}/complete", params={"status": True}
150+
)
149151
response.raise_for_status()
150152
return await self.details(todo_id)
151153

src/bloomy/operations/todos.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -145,7 +145,9 @@ def complete(self, todo_id: int) -> Todo:
145145
```
146146
147147
"""
148-
response = self._client.post(f"todo/{todo_id}/complete?status=true")
148+
response = self._client.post(
149+
f"todo/{todo_id}/complete", params={"status": True}
150+
)
149151
response.raise_for_status()
150152
return self.details(todo_id)
151153

tests/test_async_todos.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -274,7 +274,9 @@ async def test_complete(
274274
assert result.complete is True
275275

276276
# Verify the API calls
277-
mock_async_client.post.assert_called_once_with("todo/1/complete?status=true")
277+
mock_async_client.post.assert_called_once_with(
278+
"todo/1/complete", params={"status": True}
279+
)
278280
mock_async_client.get.assert_called_once_with("todo/1")
279281

280282
@pytest.mark.asyncio

tests/test_todos.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -116,7 +116,9 @@ def test_complete_todo(self, mock_http_client: Mock) -> None:
116116

117117
assert result.id == 789
118118
assert result.complete is True
119-
mock_http_client.post.assert_called_once_with("todo/789/complete?status=true")
119+
mock_http_client.post.assert_called_once_with(
120+
"todo/789/complete", params={"status": True}
121+
)
120122
mock_http_client.get.assert_called_once_with("todo/789")
121123

122124
def test_update_todo(self, mock_http_client: Mock) -> None:

0 commit comments

Comments
 (0)