Merge pull request #15 from franccesco/fix/sdk-bugfixes-v0.21.1

fix: SDK bug fixes — truthiness guards, goal owner overwrite, meeting details rewrite

Author: franccesco

.github/workflows/tests.yml

@@ -39,7 +39,7 @@ jobs:
         run: uv sync --all-extras
 
       - name: Run tests with coverage
-        run: uv run pytest --cov=bloomy --cov-report=term-missing --cov-report=xml
+        run: uv run pytest -m "not integration" --cov=bloomy --cov-report=term-missing --cov-report=xml
 
       - name: Upload coverage report
         if: matrix.python-version == '3.12'

pyproject.toml

@@ -1,6 +1,6 @@
 [project]
 name = "bloomy-python"
-version = "0.21.0"
+version = "0.21.1"
 description = "Python SDK for Bloom Growth API"
 readme = "README.md"
 authors = [{ name = "Franccesco Orozco", email = "franccesco@codingdose.info" }]
@@ -79,6 +79,9 @@ reportMissingImports = true
 testpaths = ["tests"]
 pythonpath = ["src"]
 addopts = "-ra --strict-markers --cov=bloomy --cov-report=term-missing"
+markers = [
+  "integration: marks tests that hit the real Bloom Growth API (deselect with '-m \"not integration\"')",
+]
 
 [dependency-groups]
 dev = [

src/bloomy/configuration.py

@@ -32,7 +32,10 @@ def __init__(self, api_key: str | None = None) -> None:
             ```
 
         """
-        self.api_key = api_key or os.environ.get("BG_API_KEY") or self._load_api_key()
+        stripped_key = api_key.strip() if api_key else api_key
+        self.api_key = (
+            stripped_key or os.environ.get("BG_API_KEY") or self._load_api_key()
+        )
 
     def configure_api_key(
         self, username: str, password: str, store_key: bool = False

src/bloomy/models.py

@@ -88,10 +88,10 @@ class UserSearchResult(BloomyBaseModel):
 
     id: int
     name: str
-    description: str
+    description: str | None = None
     email: str
     organization_id: int
-    image_url: str
+    image_url: str | None = None
 
 
 class UserListItem(BloomyBaseModel):
@@ -100,8 +100,8 @@ class UserListItem(BloomyBaseModel):
     id: int
     name: str
     email: str
-    position: str
-    image_url: str
+    position: str | None = None
+    image_url: str | None = None
 
 
 class MeetingAttendee(BloomyBaseModel):
@@ -265,7 +265,7 @@ class CreatedGoalInfo(BloomyBaseModel):
     user_name: str
     title: str
     meeting_id: int
-    meeting_title: str
+    meeting_title: str | None = None
     status: str
     created_at: str
 

src/bloomy/operations/async_/goals.py

@@ -103,17 +103,14 @@ async def update(
         Args:
             goal_id: The ID of the goal to update
             title: The new title of the goal
-            accountable_user: The ID of the user responsible for the goal
-                (default: initialized user ID)
+            accountable_user: The ID of the user responsible for the goal.
+                If not provided, the existing owner is preserved.
             status: The status value. Can be a GoalStatus enum member or string
                 ('on', 'off', or 'complete'). Use GoalStatus.ON_TRACK,
                 GoalStatus.AT_RISK, or GoalStatus.COMPLETE for type safety.
                 Invalid values will raise ValueError via the update payload builder.
 
         """
-        if accountable_user is None:
-            accountable_user = await self.get_user_id()
-
         payload = self._build_goal_update_payload(accountable_user, title, status)
 
         response = await self._client.put(f"rocks/{goal_id}", json=payload)

src/bloomy/operations/async_/headlines.py

@@ -56,7 +56,7 @@ async def create(
             id=data["Id"],
             title=data["Name"],
             owner_details=OwnerDetails(id=owner_id, name=None),
-            notes_url=data.get("DetailsUrl", ""),
+            notes_url=data.get("DetailsUrl") or "",
         )
 
     async def update(self, headline_id: int, title: str) -> None:
@@ -106,10 +106,10 @@ async def list(
             ValueError: If both user_id and meeting_id are provided
 
         """
-        if user_id and meeting_id:
+        if user_id is not None and meeting_id is not None:
             raise ValueError("Please provide either user_id or meeting_id, not both.")
 
-        if meeting_id:
+        if meeting_id is not None:
             response = await self._client.get(f"l10/{meeting_id}/headlines")
         else:
             if user_id is None:

src/bloomy/operations/async_/issues.py

@@ -54,12 +54,12 @@ async def list(
             ValueError: When both user_id and meeting_id are provided
 
         """
-        if user_id and meeting_id:
+        if user_id is not None and meeting_id is not None:
             raise ValueError(
                 "Please provide either `user_id` or `meeting_id`, not both."
             )
 
-        if meeting_id:
+        if meeting_id is not None:
             response = await self._client.get(f"l10/{meeting_id}/issues")
         else:
             if user_id is None:

src/bloomy/operations/async_/meetings.py

@@ -4,9 +4,8 @@
 
 import asyncio
 import builtins
-from typing import TYPE_CHECKING, Any
+from typing import Any
 
-from ...exceptions import APIError
 from ...models import (
     BulkCreateError,
     BulkCreateResult,
@@ -20,9 +19,6 @@
 from ...utils.async_base_operations import AsyncBaseOperations
 from ..mixins.meetings_transform import MeetingOperationsMixin
 
-if TYPE_CHECKING:
-    pass
-
 
 class AsyncMeetingOperations(AsyncBaseOperations, MeetingOperationsMixin):
     """Async class to handle all operations related to meetings.
@@ -176,9 +172,6 @@ async def details(
         Returns:
             A MeetingDetails model instance with comprehensive meeting information
 
-        Raises:
-            APIError: If the meeting with the given ID is not found
-
         Example:
             ```python
             await client.meeting.details(1)
@@ -187,11 +180,9 @@ async def details(
             ```
 
         """
-        meetings = await self.list()
-        meeting = next((m for m in meetings if m.id == meeting_id), None)
-
-        if not meeting:
-            raise APIError(f"Meeting with ID {meeting_id} not found", status_code=404)
+        response = await self._client.get(f"L10/{meeting_id}")
+        response.raise_for_status()
+        data: Any = response.json()
 
         # Fetch all sub-resources in parallel for better performance
         attendees_task = asyncio.create_task(self.attendees(meeting_id))
@@ -209,11 +200,11 @@ async def details(
         )
 
         return MeetingDetails(
-            id=meeting.id,
-            name=meeting.name,
-            start_date_utc=getattr(meeting, "start_date_utc", None),
-            created_date=getattr(meeting, "created_date", None),
-            organization_id=getattr(meeting, "organization_id", None),
+            id=data["Id"],
+            name=data.get("Basics", {}).get("Name", ""),
+            start_date_utc=data.get("StartDateUtc"),
+            created_date=data.get("CreateTime"),
+            organization_id=data.get("OrganizationId"),
             attendees=attendees,
             issues=issues,
             todos=todos,

src/bloomy/operations/async_/scorecard.py

@@ -51,12 +51,12 @@ async def list(
             ValueError: If both user_id and meeting_id are provided
 
         """
-        if user_id and meeting_id:
+        if user_id is not None and meeting_id is not None:
             raise ValueError(
                 "Please provide either `user_id` or `meeting_id`, not both."
             )
 
-        if meeting_id:
+        if meeting_id is not None:
             response = await self._client.get(f"scorecard/meeting/{meeting_id}")
         else:
             if user_id is None:

src/bloomy/operations/async_/todos.py

@@ -3,7 +3,7 @@
 from __future__ import annotations
 
 import builtins
-from datetime import datetime
+from datetime import UTC, datetime
 from typing import TYPE_CHECKING
 
 from ...models import BulkCreateResult, Todo
@@ -120,7 +120,7 @@ async def create(
             "DetailsUrl": data.get("DetailsUrl"),
             "DueDate": data.get("DueDate"),
             "CompleteTime": None,
-            "CreateTime": data.get("CreateTime", datetime.now().isoformat()),
+            "CreateTime": data.get("CreateTime", datetime.now(UTC).isoformat()),
             "OriginId": meeting_id,
             "Origin": None,
             "Complete": False,