test: update tests for new update() return types

Adapt goal and headline update tests to expect returned objects instead of
None, and add GET mocks for the post-update details() re-fetch.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Author: franccesco

tests/test_adversarial_todos_goals.py

@@ -68,6 +68,22 @@ class TestGoalUpdateOverwritesOwner:
     overwriting the goal owner. This has been fixed.
     """
 
+    @pytest.fixture(autouse=True)
+    def _setup_goal_get_response(self, mock_http_client: Mock) -> None:
+        """Configure GET to return a valid goal response for the details() re-fetch."""
+        get_response = Mock()
+        get_response.raise_for_status = Mock()
+        get_response.json.return_value = {
+            "Id": 1,
+            "Owner": {"Id": 123, "Name": "Alice"},
+            "Name": "Goal Title",
+            "CreateTime": "2024-01-01T00:00:00Z",
+            "DueDate": "2024-12-31",
+            "Complete": False,
+            "Origins": [{"Id": 100, "Name": "Meeting A"}],
+        }
+        mock_http_client.get.return_value = get_response
+
     def test_update_title_only_should_not_overwrite_owner(
         self, mock_http_client: Mock, mock_user_id: PropertyMock
     ) -> None:

tests/test_async_goals.py

@@ -190,15 +190,30 @@ async def test_update(
         self, async_client: AsyncClient, mock_async_client: AsyncMock
     ):
         """Test updating a goal."""
-        mock_response = MagicMock()
-        mock_response.raise_for_status = MagicMock()
-        mock_async_client.put.return_value = mock_response
+        mock_put_response = MagicMock()
+        mock_put_response.raise_for_status = MagicMock()
+        mock_async_client.put.return_value = mock_put_response
+
+        mock_get_response = MagicMock()
+        mock_get_response.raise_for_status = MagicMock()
+        mock_get_response.json.return_value = {
+            "Id": 123,
+            "Owner": {"Id": 1, "Name": "John Doe"},
+            "Name": "Updated Goal",
+            "CreateTime": "2024-01-01T00:00:00Z",
+            "DueDate": "2024-06-01",
+            "Complete": False,
+            "Origins": [{"Id": 10, "Name": "Team Meeting"}],
+        }
+        mock_async_client.get.return_value = mock_get_response
 
         result = await async_client.goal.update(
             goal_id=123, title="Updated Goal", status="on"
         )
 
-        assert result is None
+        assert isinstance(result, GoalInfo)
+        assert result.id == 123
+        assert result.title == "Updated Goal"
         mock_async_client.put.assert_called_once_with(
             "rocks/123",
             json={

tests/test_async_headlines.py

@@ -86,15 +86,31 @@ async def test_update(
         self, async_client: AsyncClient, mock_async_client: AsyncMock
     ):
         """Test updating a headline."""
-        mock_response = MagicMock()
-        mock_response.raise_for_status = MagicMock()
-        mock_async_client.put.return_value = mock_response
+        mock_put_response = MagicMock()
+        mock_put_response.raise_for_status = MagicMock()
+        mock_async_client.put.return_value = mock_put_response
+
+        mock_get_response = MagicMock()
+        mock_get_response.raise_for_status = MagicMock()
+        mock_get_response.json.return_value = {
+            "Id": 501,
+            "Name": "Updated headline",
+            "DetailsUrl": "https://example.com/headline/501",
+            "Owner": {"Id": 123, "Name": "John Doe"},
+            "Origin": "Product Meeting",
+            "OriginId": 456,
+            "Archived": False,
+            "CreateTime": "2024-06-01T10:00:00Z",
+            "CloseTime": None,
+        }
+        mock_async_client.get.return_value = mock_get_response
 
         result = await async_client.headline.update(
             headline_id=501, title="Updated headline"
         )
 
-        assert result is None
+        assert isinstance(result, HeadlineDetails)
+        assert result.id == 501
         mock_async_client.put.assert_called_once_with(
             "headline/501", json={"title": "Updated headline"}
         )

tests/test_goals.py

@@ -109,16 +109,27 @@ def test_delete_goal(self, mock_http_client: Mock) -> None:
         assert result is None
         mock_http_client.delete.assert_called_once_with("rocks/101")
 
-    def test_update_goal(self, mock_http_client: Mock, mock_user_id: Mock) -> None:
+    def test_update_goal(
+        self,
+        mock_http_client: Mock,
+        mock_user_id: Mock,
+        sample_goal_data: dict[str, Any],
+    ) -> None:
         """Test updating a goal."""
-        mock_response = Mock()
-        mock_http_client.put.return_value = mock_response
+        mock_put_response = Mock()
+        mock_http_client.put.return_value = mock_put_response
+
+        mock_get_response = Mock()
+        mock_get_response.json.return_value = sample_goal_data
+        mock_http_client.get.return_value = mock_get_response
 
         goal_ops = GoalOperations(mock_http_client)
 
+        from bloomy.models import GoalInfo
+
         result = goal_ops.update(goal_id=101, title="Updated Goal", status="complete")
 
-        assert result is None
+        assert isinstance(result, GoalInfo)
         mock_http_client.put.assert_called_once_with(
             "rocks/101",
             json={

tests/test_headlines.py

@@ -69,16 +69,24 @@ def test_create_default_owner(
             json={"title": "Product launch successful", "ownerId": 123},
         )
 
-    def test_update(self, mock_http_client: Mock) -> None:
+    def test_update(
+        self, mock_http_client: Mock, sample_headline_data: dict[str, Any]
+    ) -> None:
         """Test updating a headline."""
-        mock_response = Mock()
-        mock_response.json.return_value = {"Id": 501, "Name": "Updated headline"}
-        mock_http_client.put.return_value = mock_response
+        mock_put_response = Mock()
+        mock_http_client.put.return_value = mock_put_response
+
+        mock_get_response = Mock()
+        mock_get_response.json.return_value = sample_headline_data
+        mock_http_client.get.return_value = mock_get_response
 
         headline_ops = HeadlineOperations(mock_http_client)
         result = headline_ops.update(headline_id=501, title="Updated headline")
 
-        assert result is None
+        from bloomy.models import HeadlineDetails
+
+        assert isinstance(result, HeadlineDetails)
+        assert result.id == 501
 
         mock_http_client.put.assert_called_once_with(
             "headline/501", json={"title": "Updated headline"}