fix(deploy): add ecosystem.production.config.js + fix uv PATH (#727) (#799)

* fix(deploy): add ecosystem.production.config.js + fix uv PATH (#727)

The production deploy job ran 'pm2 start ecosystem.production.config.js' (file
never existed — only staging) and exported PATH="$HOME/.cargo/bin:$PATH"
unescaped (expands on the runner, wrong dir) while uv installs to ~/.local/bin.
A fresh production host aborted under set -e / couldn't find uv.

- add ecosystem.production.config.js mirroring staging; app names + ports read
  from env (.env.production / deploy shell) so 'pm2 --only "$PM2_*_NAME"'
  matches the deploy's secret-provided names (defaults otherwise)
- fix the prod uv PATH to '$HOME/.local/bin' (escaped, matches staging)
- smoke tests: config exists + loads (node) with 2 apps; deploy.yml has no
  dangling ecosystem ref and no cargo/bin PATH

Closes #727

* test(deploy): use node --check (dependency-free) + static app check; hoist re import (#727 CI + review)

The node smoke test require()'d dotenv, which isn't installed at the repo root
in the Backend Unit Tests job (only web-ui/ runs npm). node --check validates
syntax without module resolution, and a static check confirms the two apps.

Author: frankbria

.github/workflows/deploy.yml

@@ -491,7 +491,9 @@ jobs:
             echo "🐍 Setting up Python backend..."
             if ! command -v uv &> /dev/null; then
               curl -LsSf https://astral.sh/uv/install.sh | sh
-              export PATH="$HOME/.cargo/bin:$PATH"
+              # uv installs to ~/.local/bin, and \$HOME must expand on the host
+              # (not the runner) — mirror the staging job (#727).
+              export PATH="\$HOME/.local/bin:\$PATH"
             fi
             uv venv --clear
             source .venv/bin/activate

ecosystem.production.config.js

@@ -0,0 +1,61 @@
+const path = require('path');
+const dotenv = require('dotenv');
+
+// Use relative paths - no hardcoded absolute paths
+const PROJECT_ROOT = __dirname;
+
+// Load environment variables from .env.production
+const envConfig = dotenv.config({ path: path.join(PROJECT_ROOT, '.env.production') }).parsed || {};
+
+// PM2 app names and ports are read from the environment (.env.production or the
+// deploy shell) so `pm2 start ecosystem.production.config.js --only "$NAME"`
+// matches whatever PM2_BACKEND_NAME / PM2_FRONTEND_NAME the deploy passes
+// (#727). Defaults are used only when those are unset.
+const BACKEND_NAME =
+  process.env.PM2_BACKEND_NAME || envConfig.PM2_BACKEND_NAME || 'codeframe-production-backend';
+const FRONTEND_NAME =
+  process.env.PM2_FRONTEND_NAME || envConfig.PM2_FRONTEND_NAME || 'codeframe-production-frontend';
+const BACKEND_PORT = process.env.BACKEND_PORT || envConfig.BACKEND_PORT || '8000';
+const FRONTEND_PORT = process.env.FRONTEND_PORT || envConfig.FRONTEND_PORT || '3000';
+
+module.exports = {
+  apps: [
+    {
+      name: BACKEND_NAME,
+      script: path.join(PROJECT_ROOT, '.venv/bin/python'),
+      args: `-m codeframe.ui.server --port ${BACKEND_PORT}`,
+      cwd: PROJECT_ROOT,
+      env: {
+        ...envConfig,
+        PYTHONPATH: PROJECT_ROOT
+      },
+      autorestart: true,
+      watch: false,
+      max_memory_restart: '500M',
+      error_file: path.join(PROJECT_ROOT, 'logs/backend-error.log'),
+      out_file: path.join(PROJECT_ROOT, 'logs/backend-out.log'),
+      log_date_format: 'YYYY-MM-DD HH:mm:ss Z',
+      kill_timeout: 5000,
+      wait_ready: true,
+      listen_timeout: 10000
+    },
+    {
+      name: FRONTEND_NAME,
+      script: path.join(PROJECT_ROOT, 'web-ui/node_modules/.bin/next'),
+      args: `start -H 0.0.0.0 -p ${FRONTEND_PORT}`,
+      cwd: path.join(PROJECT_ROOT, 'web-ui'),
+      env: {
+        ...envConfig
+      },
+      autorestart: true,
+      watch: false,
+      max_memory_restart: '500M',
+      error_file: path.join(PROJECT_ROOT, 'logs/frontend-error.log'),
+      out_file: path.join(PROJECT_ROOT, 'logs/frontend-out.log'),
+      log_date_format: 'YYYY-MM-DD HH:mm:ss Z',
+      kill_timeout: 5000,
+      wait_ready: true,
+      listen_timeout: 10000
+    }
+  ]
+};

tests/test_deploy_config.py

@@ -0,0 +1,64 @@
+"""Production deploy smoke checks (#727 / P0.16).
+
+The production deploy job referenced a missing ecosystem.production.config.js
+and exported a wrong uv PATH ($HOME/.cargo/bin, unescaped), so a fresh
+production host aborted under `set -e`. These guard against regressions.
+"""
+
+import re
+import shutil
+import subprocess
+from pathlib import Path
+
+import pytest
+
+pytestmark = pytest.mark.v2
+
+REPO = Path(__file__).resolve().parents[1]
+DEPLOY_YML = REPO / ".github" / "workflows" / "deploy.yml"
+PROD_ECOSYSTEM = REPO / "ecosystem.production.config.js"
+
+
+def test_production_ecosystem_config_exists():
+    assert PROD_ECOSYSTEM.is_file(), (
+        "ecosystem.production.config.js must exist — deploy.yml runs "
+        "`pm2 start ecosystem.production.config.js`"
+    )
+
+
+def test_deploy_uses_correct_uv_path():
+    text = DEPLOY_YML.read_text()
+    # The broken cargo path must be gone...
+    assert "cargo/bin" not in text, "deploy.yml still exports the wrong uv PATH (cargo/bin)"
+    # ...and every uv PATH export uses the escaped ~/.local/bin (expands on the host).
+    assert 'export PATH="\\$HOME/.local/bin:\\$PATH"' in text
+
+
+def test_no_dangling_ecosystem_reference():
+    """Every ecosystem.*.config.js file the workflow starts must exist."""
+    text = DEPLOY_YML.read_text()
+    for name in set(re.findall(r"ecosystem\.[\w.]*config\.js", text)):
+        assert (REPO / name).is_file(), f"deploy.yml references missing {name}"
+
+
+@pytest.mark.skipif(shutil.which("node") is None, reason="node not available")
+def test_production_config_is_valid_javascript():
+    """Smoke-test: the config parses as valid JS. `node --check` is syntax-only
+    (no execution / module resolution), so it doesn't need the root npm deps
+    that only exist on the deploy host, yet still catches a broken config."""
+    result = subprocess.run(
+        ["node", "--check", "ecosystem.production.config.js"],
+        cwd=str(REPO),
+        capture_output=True,
+        text=True,
+    )
+    assert result.returncode == 0, result.stderr
+
+
+def test_production_config_defines_two_apps():
+    """The config must define backend + frontend apps. Checked statically so it
+    needs no node/npm deps: both app blocks reference the venv python and next."""
+    text = PROD_ECOSYSTEM.read_text()
+    assert ".venv/bin/python" in text  # backend app
+    assert "web-ui/node_modules/.bin/next" in text  # frontend app
+    assert text.count("name:") == 2  # exactly two pm2 apps