ci(e2e): formally defer Playwright browser E2E + fix legacy comments (#647) (#685)

frankbria · web-flow · commit bb393b70a113 · 2026-06-15T13:04:29.000-07:00
The two browser-level Playwright jobs (e2e-smoke-tests, e2e-frontend-tests) were commented out with "web-ui is legacy during v2 CLI-first refactor" — contradicting CLAUDE.md (web UI is actively developed). They can't simply be re-enabled: the tests/e2e/*.spec.ts suite targets a /projects/[id] route architecture the current Phase-3+ workspace UI no longer has (19/19 specs reference /projects; navigates to /projects/${id} 36+ times), so it fails as-is. Formally defer instead of leaving a misleading disable: - Remove the 326 lines of stale commented-out job bodies (preserved in git history); replace with a concise deferral note referencing the rewrite issue. - Correct the schedule-cron comment and remove the "legacy" claim. - Rewrite tracked in #684. No functional CI change (jobs were already not running); test-summary wiring unchanged. The remaining "legacy" reference (line ~250) is about v1 Python modules, not the web UI. Closes #647
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
@@ -6,9 +6,11 @@ on:
   pull_request:
     branches: [main, develop]
   workflow_call:  # Allow this workflow to be called by other workflows
+  # Nightly browser-E2E schedule is intentionally OFF: the Playwright E2E suite is
+  # deferred pending a rewrite against the current Phase-3+ UI (tracked in #684).
+  # Re-enable this cron once those jobs are green.
   # schedule:
-    # Run E2E tests nightly at 2 AM UTC
-    # - cron: '0 2 * * *'
+  #   - cron: '0 2 * * *'
 
 env:
   PYTHON_VERSION: '3.11'
@@ -426,331 +428,15 @@ jobs:
           retention-days: 7
 
   # ============================================
-  # E2E Smoke Tests (Playwright - Chromium only)
+  # E2E Browser Tests (Playwright) — DEFERRED (see #684)
   # ============================================
-  # DISABLED: web-ui is legacy during v2 CLI-first refactor
-  # Re-enable when web-ui package.json is restored
-  # e2e-smoke-tests:
-  #   name: E2E Smoke Tests (Chromium)
-  #   runs-on: ubuntu-latest
-  #   # Run on PRs for fast feedback
-  #   if: github.event_name == 'pull_request'
-  #
-  #   steps:
-  #     - name: Checkout code
-  #       uses: actions/checkout@v4
-  #
-  #     - name: Set up Node.js
-  #       uses: actions/setup-node@v4
-  #       with:
-  #         node-version: ${{ env.NODE_VERSION }}
-  #         cache: 'npm'
-  #         cache-dependency-path: 'web-ui/package-lock.json'
-  #
-  #     - name: Set up Python
-  #       uses: actions/setup-python@v5
-  #       with:
-  #         python-version: ${{ env.PYTHON_VERSION }}
-  #
-  #     - name: Install uv
-  #       uses: astral-sh/setup-uv@v4
-  #       with:
-  #         enable-cache: true
-  #
-  #     - name: Install Python dependencies
-  #       run: |
-  #         uv venv
-  #         uv sync
-  #
-  #     - name: Install frontend dependencies
-  #       working-directory: web-ui
-  #       run: npm ci
-  #
-  #     - name: Install E2E test dependencies
-  #       working-directory: tests/e2e
-  #       run: |
-  #         npm ci
-  #         # Rebuild native modules for current Node.js version
-  #         # (better-sqlite3 requires matching NODE_MODULE_VERSION)
-  #         npm rebuild better-sqlite3
-  #
-  #     - name: Install Playwright browsers (Chromium only)
-  #       working-directory: tests/e2e
-  #       run: npx playwright install chromium --with-deps
-  #
-  #     - name: Install codeframe package
-  #       run: |
-  #         uv pip install -e .
-  #         echo "✅ Package installed in editable mode"
-  #
-  #     - name: Initialize database
-  #       run: |
-  #         # E2E tests expect database at tests/e2e/.codeframe/state.db
-  #         mkdir -p tests/e2e/.codeframe
-  #         source .venv/bin/activate
-  #         python -c "from codeframe.platform_store.database import Database; db = Database('tests/e2e/.codeframe/state.db'); db.initialize(); db.close()"
-  #         echo "✅ Database initialized at tests/e2e/.codeframe/state.db"
-  #
-  #     - name: Start backend server
-  #       env:
-  #         # Must match TEST_DB_PATH in tests/e2e/e2e-config.ts
-  #         DATABASE_PATH: ${{ github.workspace }}/tests/e2e/.codeframe/state.db
-  #         WORKSPACE_ROOT: ${{ github.workspace }}
-  #         CODEFRAME_DEPLOYMENT_MODE: self_hosted
-  #       run: |
-  #         source .venv/bin/activate
-  #         python -m uvicorn codeframe.ui.server:app --port 8080 > /tmp/backend.log 2>&1 &
-  #         echo "BACKEND_PID=$!" >> $GITHUB_ENV
-  #         echo "Backend started with PID: $!"
-  #
-  #     - name: Wait for backend to be ready
-  #       run: |
-  #         echo "Waiting for backend to start..."
-  #         for i in {1..120}; do
-  #           if curl -s http://localhost:8080/health > /dev/null; then
-  #             echo "✅ Backend is ready!"
-  #             curl -s http://localhost:8080/health | jq .
-  #             break
-  #           fi
-  #           echo "Attempt $i/120: Backend not ready yet..."
-  #           sleep 1
-  #           if [ $i -eq 120 ]; then
-  #             echo "❌ Backend failed to start within 120 seconds"
-  #             cat /tmp/backend.log
-  #             exit 1
-  #           fi
-  #         done
-  #
-  #     - name: Start frontend dev server
-  #       working-directory: web-ui
-  #       env:
-  #         PORT: 3001
-  #         NEXT_PUBLIC_API_URL: http://localhost:8080
-  #       run: |
-  #         npm run dev > /tmp/frontend.log 2>&1 &
-  #         echo "FRONTEND_PID=$!" >> $GITHUB_ENV
-  #         echo "Frontend started with PID: $! on port 3001"
-  #
-  #     - name: Wait for frontend to be ready
-  #       run: |
-  #         echo "Waiting for frontend to start on port 3001..."
-  #         for i in {1..60}; do
-  #           if curl -s http://localhost:3001 > /dev/null; then
-  #             echo "✅ Frontend is ready on port 3001!"
-  #             break
-  #           fi
-  #           echo "Attempt $i/60: Frontend not ready yet..."
-  #           sleep 1
-  #           if [ $i -eq 60 ]; then
-  #             echo "❌ Frontend failed to start within 60 seconds"
-  #             cat /tmp/frontend.log
-  #             exit 1
-  #           fi
-  #         done
-  #
-  #     - name: Run Playwright smoke tests (Chromium only)
-  #       working-directory: tests/e2e
-  #       run: npm run test:smoke
-  #
-  #     - name: Upload Playwright report
-  #       if: always()
-  #       uses: actions/upload-artifact@v4
-  #       with:
-  #         name: playwright-smoke-report
-  #         path: tests/e2e/playwright-report/
-  #         retention-days: 7
-  #
-  #     - name: Upload backend logs
-  #       if: always()
-  #       uses: actions/upload-artifact@v4
-  #       with:
-  #         name: e2e-smoke-backend-logs
-  #         path: /tmp/backend.log
-  #         retention-days: 7
-  #
-  #     - name: Upload frontend logs
-  #       if: always()
-  #       uses: actions/upload-artifact@v4
-  #       with:
-  #         name: e2e-smoke-frontend-logs
-  #         path: /tmp/frontend.log
-  #         retention-days: 7
-  #
-  #     - name: Stop servers
-  #       if: always()
-  #       run: |
-  #         if [ -n "$BACKEND_PID" ]; then
-  #           kill $BACKEND_PID || true
-  #         fi
-  #         if [ -n "$FRONTEND_PID" ]; then
-  #           kill $FRONTEND_PID || true
-  #         fi
-
-  # ============================================
-  # E2E Frontend Tests (Playwright - All Browsers)
-  # ============================================
-  # COMMENTED OUT: Enable when smoke tests are passing consistently
-  # e2e-frontend-tests:
-  #   name: E2E Frontend Tests (All Browsers)
-  #   runs-on: ubuntu-latest
-  #   # Only run on main branch or scheduled runs
-  #   if: github.ref == 'refs/heads/main' || github.event_name == 'schedule'
-  #
-  #   steps:
-  #     - name: Checkout code
-  #       uses: actions/checkout@v4
-  #
-  #     - name: Set up Node.js
-  #       uses: actions/setup-node@v4
-  #       with:
-  #         node-version: ${{ env.NODE_VERSION }}
-  #         cache: 'npm'
-  #         cache-dependency-path: 'web-ui/package-lock.json'
-  #
-  #     - name: Set up Python
-  #       uses: actions/setup-python@v5
-  #       with:
-  #         python-version: ${{ env.PYTHON_VERSION }}
-  #
-  #     - name: Install uv
-  #       uses: astral-sh/setup-uv@v4
-  #       with:
-  #         enable-cache: true
-  #
-  #     - name: Install Python dependencies
-  #       run: |
-  #         uv venv
-  #         uv sync
-  #
-  #     - name: Install frontend dependencies
-  #       working-directory: web-ui
-  #       run: npm ci
-  #
-  #     - name: Install E2E test dependencies
-  #       working-directory: tests/e2e
-  #       run: npm ci
-  #
-  #     - name: Install Playwright browsers
-  #       working-directory: tests/e2e
-  #       run: npx playwright install --with-deps
-  #
-  #     - name: Install codeframe package
-  #       run: |
-  #         uv pip install -e .
-  #         echo "✅ Package installed in editable mode"
-  #
-  #     - name: Initialize database
-  #       run: |
-  #         mkdir -p .codeframe
-  #         source .venv/bin/activate
-  #         python -c "from codeframe.platform_store.database import Database; db = Database('.codeframe/state.db'); db.initialize(); db.close()"
-  #         echo "✅ Database initialized"
-  #
-  #     - name: Start backend server
-  #       env:
-  #         DATABASE_PATH: ${{ github.workspace }}/.codeframe/state.db
-  #         WORKSPACE_ROOT: ${{ github.workspace }}
-  #         CODEFRAME_DEPLOYMENT_MODE: self_hosted
-  #       run: |
-  #         source .venv/bin/activate
-  #         python -m uvicorn codeframe.ui.server:app --port 8080 > /tmp/backend.log 2>&1 &
-  #         echo "BACKEND_PID=$!" >> $GITHUB_ENV
-  #         echo "Backend started with PID: $!"
-  #
-  #     - name: Verify backend startup
-  #       run: |
-  #         sleep 5
-  #         if ! ps -p $BACKEND_PID > /dev/null; then
-  #           echo "❌ Backend process died immediately"
-  #           cat /tmp/backend.log
-  #           exit 1
-  #         fi
-  #         echo "✅ Backend process is running (PID: $BACKEND_PID)"
-  #
-  #     - name: Wait for backend to be ready
-  #       run: |
-  #         echo "Waiting for backend to start..."
-  #         for i in {1..120}; do
-  #           if curl -s http://localhost:8080/health > /dev/null; then
-  #             echo "✅ Backend is ready!"
-  #             curl -s http://localhost:8080/health | jq .
-  #             break
-  #           fi
-  #           echo "Attempt $i/120: Backend not ready yet..."
-  #           sleep 1
-  #           if [ $i -eq 120 ]; then
-  #             echo "❌ Backend failed to start within 120 seconds"
-  #             echo "=== Backend Logs ==="
-  #             cat /tmp/backend.log
-  #             exit 1
-  #           fi
-  #         done
-  #
-  #     - name: Start frontend dev server
-  #       working-directory: web-ui
-  #       run: |
-  #         npm run dev > /tmp/frontend.log 2>&1 &
-  #         echo "FRONTEND_PID=$!" >> $GITHUB_ENV
-  #         echo "Frontend started with PID: $!"
-  #
-  #     - name: Wait for frontend to be ready
-  #       run: |
-  #         echo "Waiting for frontend to start..."
-  #         for i in {1..60}; do
-  #           if curl -s http://localhost:3000 > /dev/null; then
-  #             echo "✅ Frontend is ready!"
-  #             break
-  #           fi
-  #           echo "Attempt $i/60: Frontend not ready yet..."
-  #           sleep 1
-  #           if [ $i -eq 60 ]; then
-  #             echo "❌ Frontend failed to start within 60 seconds"
-  #             echo "=== Frontend Logs ==="
-  #             cat /tmp/frontend.log
-  #             exit 1
-  #           fi
-  #         done
-  #
-  #     - name: Run Playwright E2E tests
-  #       working-directory: tests/e2e
-  #       run: |
-  #         npx playwright test \
-  #           --config=playwright.config.ts \
-  #           *.spec.ts
-  #
-  #     - name: Upload Playwright report
-  #       if: always()
-  #       uses: actions/upload-artifact@v4
-  #       with:
-  #         name: playwright-report
-  #         path: tests/e2e/playwright-report/
-  #         retention-days: 30
-  #
-  #     - name: Upload backend logs
-  #       if: always()
-  #       uses: actions/upload-artifact@v4
-  #       with:
-  #         name: e2e-frontend-backend-logs
-  #         path: /tmp/backend.log
-  #         retention-days: 7
-  #
-  #     - name: Upload frontend logs
-  #       if: always()
-  #       uses: actions/upload-artifact@v4
-  #       with:
-  #         name: e2e-frontend-frontend-logs
-  #         path: /tmp/frontend.log
-  #         retention-days: 7
-  #
-  #     - name: Stop servers
-  #       if: always()
-  #       run: |
-  #         if [ -n "$BACKEND_PID" ]; then
-  #           kill $BACKEND_PID || true
-  #         fi
-  #         if [ -n "$FRONTEND_PID" ]; then
-  #           kill $FRONTEND_PID || true
-  #         fi
+  # The browser-level Playwright E2E jobs (Chromium smoke + all-browsers) are
+  # intentionally deferred, not abandoned. The tests/e2e/*.spec.ts suite targets a
+  # /projects/[id] route architecture that the current Phase-3+ workspace UI no
+  # longer has (pages are /tasks, /execution, /proof, etc.), so it cannot pass
+  # as-is and needs a rewrite. Tracked in issue #684. The nightly `schedule:` cron
+  # at the top of this file stays off until that rewrite lands and the jobs are
+  # green. The prior (stale) job definitions remain available in git history.
 
   # ============================================
   # TestSprite E2E Tests (Optional)
