fix(ci): unblock Full Lifecycle Tests workflow (#592)

* fix(ci): unblock Full Lifecycle Tests workflow

Weekly scheduled run failed with `pytest: error: unrecognized
arguments: --timeout=1800` because pytest-timeout was passed to pytest
but never declared as a dev dependency.

- Add pytest-timeout>=2.3.0 to [project.optional-dependencies].dev
- Scope lifecycle job to `environment: staging` so it can resolve
  ANTHROPIC_API_KEY (currently only present on the staging env, not at
  repo level), otherwise conftest skips the entire suite.
- Capture pytest stdout/stderr to artifacts/pytest.log via tee and use
  --basetemp inside the workspace, so failure artifacts upload even
  when pytest fails to start.

* fix(test): drop invalid --execute flag from cf work batch run calls

The lifecycle CLI test passed `--execute` to `cf work batch run`, but
that flag only exists on `cf work start` (single task). Batch always
executes (use `--dry-run` to preview). The flag was silently broken
since the test was added (bdb6686) because the lifecycle suite was
never green in CI — the pytest-timeout dep error masked it.

Fixes the AssertionError surfaced by the first non-skipped lifecycle
run after the dep fix:

  Error: No such option: --execute

* fix(test): promote BACKLOG→READY in lifecycle fixture

`cf tasks generate` creates tasks in BACKLOG status by design (the CLI
prints next-step hints suggesting `cf tasks set status READY --all` to
promote them). The lifecycle fixture skipped this step, so
`cf work batch run --all-ready` returned "No READY tasks found" and
exited 0 — the test passed the batch-run assertion but the agent
never actually built anything, and acceptance checks correctly
flagged the missing csv_stats.py.

Add the promotion step to initialized_workspace and update the
docstring (which still referenced the no-longer-valid --execute flag).

---------

Co-authored-by: Test User <test@example.com>

Author: frankbria

.github/workflows/lifecycle.yml

@@ -30,6 +30,7 @@ jobs:
   lifecycle:
     name: Lifecycle (${{ inputs.mode || 'cli' }} / ${{ inputs.model || 'haiku' }})
     runs-on: ubuntu-latest
+    environment: staging
     timeout-minutes: 60
 
     steps:
@@ -73,19 +74,24 @@ jobs:
           ANTHROPIC_API_KEY: ${{ secrets.ANTHROPIC_API_KEY }}
           CODEFRAME_LIFECYCLE_MODEL: ${{ inputs.model || 'haiku' }}
         run: |
+          mkdir -p artifacts
           uv run pytest ${{ steps.tests.outputs.path }} \
             -m lifecycle \
             -v \
             --tb=long \
             --no-header \
             -p no:warnings \
-            --timeout=1800
+            --timeout=1800 \
+            --basetemp=artifacts/pytest \
+            2>&1 | tee artifacts/pytest.log
+          exit "${PIPESTATUS[0]}"
 
       - name: Upload test artifacts on failure
         if: failure()
         uses: actions/upload-artifact@v4
         with:
           name: lifecycle-failure-${{ github.run_id }}
           path: |
-            /tmp/pytest-*/
+            artifacts/
           retention-days: 7
+          if-no-files-found: warn

pyproject.toml

@@ -70,6 +70,7 @@ dev = [
     "pytest-asyncio>=0.23.0",
     "pytest-cov>=4.1.0",
     "pytest-json-report>=1.5.0",
+    "pytest-timeout>=2.3.0",
     "black>=24.1.0",
     "ruff>=0.2.0",
     "mypy>=1.8.0",

tests/lifecycle/conftest.py

@@ -94,8 +94,8 @@ def initialized_workspace(target_project_dir, cf, sample_prd_path):
     A workspace with:
     - cf init complete
     - PRD added
-    - Tasks generated
-    Ready for `cf work batch run --all-ready --execute`.
+    - Tasks generated and promoted from BACKLOG → READY
+    Ready for `cf work batch run --all-ready`.
     """
     result = cf("init", str(target_project_dir), "--tech-stack", "Python with uv")
     assert result.returncode == 0, f"cf init failed:\n{result.stderr}"
@@ -110,4 +110,9 @@ def initialized_workspace(target_project_dir, cf, sample_prd_path):
     result = cf("tasks", "generate")
     assert result.returncode == 0, f"cf tasks generate failed:\n{result.stderr}"
 
+    # `cf tasks generate` creates BACKLOG tasks; promote to READY so the
+    # batch runner picks them up via --all-ready.
+    result = cf("tasks", "set", "status", "READY", "--all", "--from", "BACKLOG")
+    assert result.returncode == 0, f"cf tasks set status READY failed:\n{result.stderr}"
+
     return target_project_dir

tests/lifecycle/test_cli_lifecycle.py

@@ -39,7 +39,6 @@ def test_agent_builds_csv_stats_project(self, initialized_workspace, cf):
         result = cf(
             "work", "batch", "run",
             "--all-ready",
-            "--execute",
             "--engine", "react",
             "--retry", "1",
             timeout=1800,  # 30 min ceiling
@@ -68,7 +67,7 @@ def test_agent_task_status_after_execution(self, initialized_workspace, cf):
         """All tasks reach DONE or BLOCKED status — none stuck in IN_PROGRESS."""
         cf(
             "work", "batch", "run",
-            "--all-ready", "--execute", "--engine", "react",
+            "--all-ready", "--engine", "react",
             timeout=1800,
         )