Skip to content

[P6.8.4] frontend lint: resolve 7 react-hooks/exhaustive-deps warnings #682

Description

@frankbria

Context

Follow-up from #646 (PR #681), which re-enabled frontend lint in CI. ESLint exits 0 on warnings (no --max-warnings), so lint is green, but 7 react-hooks/exhaustive-deps warnings remain in pre-existing components and should not silently accumulate.

Warnings

  • src/app/proof/[req_id]/page.tsx:88 — missing dep reqId
  • src/components/execution/BatchExecutionMonitor.tsx:105 — missing dep batch
  • src/components/prd/DiscoveryPanel.tsx:83 — missing dep startNewSession
  • src/components/prd/StressTestModal.tsx:75ambiguities logical expr (×2, useMemo deps)
  • src/components/tasks/GitHubIssueImportModal.tsx:94issues logical expr (×2, useMemo/useCallback deps)

Why deferred

Each fix is behavioral (changing hook deps can alter render/effect timing) and out of scope for the CI-hardening issue #646. Resolving them needs per-component verification, not a blanket autofix.

Acceptance criteria

  • All 7 warnings resolved without regressions (verify each component's behavior)
  • Optionally consider --max-warnings 0 in the lint step once clean, to prevent regressions

Metadata

Metadata

Assignees

No one assigned

    Labels

    P3-post-betaLow priority - can wait until after beta (v2.0)ci-cdphase-6.8Phase 6.8: Test coverage hardeningtooling

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions