Skip to content

Linter fixes on redshift schema group#43

Open
raymondberg wants to merge 8 commits into
frankfarrell:masterfrom
raymondberg:master
Open

Linter fixes on redshift schema group#43
raymondberg wants to merge 8 commits into
frankfarrell:masterfrom
raymondberg:master

Conversation

@raymondberg
Copy link
Copy Markdown

Problem

The linter fails on master and blocks builds. 😢

> make build
==> Checking that code complies with gofmt requirements...         
gofmt needs running on the following files:                            
./redshift/resource_redshift_schema_group_privilege.go                 
You can use the command: `make fmt` to reformat code. 
make: *** [GNUmakefile:28: fmtcheck] Error 1       

Solution

Run the linter! 😄

Copy link
Copy Markdown

@coopergillan coopergillan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧧

raymondberg and others added 7 commits February 4, 2021 15:04
Linter fixes on redshift schema group
__Problem__

The binaries directory grows by a few dozen MB every release, keeping
these checked in as code is not ideal for developers or users.

__Solution__

Add a .gitignore and rely on copies included in tag releases.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants