Refactor editor attribute sorting logic

[stijnpotters1]

[philipsens]

Sorry that I'm only jumping in now, but can you explain what order is being used for the attributes now. I commented on the issue (#374 (comment)), but didn't realize that there was a PR already.

[stijnpotters1]

Sorry that I'm only jumping in now, but can you explain what order is being used for the attributes now. I commented on the issue (#374 (comment)), but didn't realize that there was a PR already.

Its sorted in 4 layers.

First on namespaced attributes
Second on mandatory attributes according tot the xsd
Thirth the name attribute since this is used almost in every element.
Fourth the rest of the attributes on alphabetical order

[philipsens]

I'd rather see the order that is used in the XSD itself (and required at the top maybe). Then there is "less magic" and is inline with the FF! Doc.

[philipsens]

We also discussed with in the Core Refining:

Why not just sort in the order of the XSD?

On another note: I don't think the editor should reformat automatically at all. Maybe when > switching context, but never when the user is focused on the editor.

So:

User is typing, saving, editing again -> Nothing should change
User calls reformat function -> Reformat and reorder
User edits flow -> XML gets changes programmatically and gets reformatted and reordered
Maybe: User loses editor focus, changes tab/file or page -> auto-reformat

The order in the FF! Doc is as follows:

• Required attributes
• Order of the XSD

The order of the XSD is actually important because it is sorted by input/output rather than alphabetically.

The Flow also had namespaces in the XML. I don't care where they are shown (At top or bottom) as long as they are together and also in the order of the XSD.

[philipsens]

Just to block merging until order and usability have been confirmed/implemented.

[stijnpotters1]

We also discussed with in the Core Refining:

Why not just sort in the order of the XSD?
On another note: I don't think the editor should reformat automatically at all. Maybe when > switching context, but never when the user is focused on the editor.

So:

User is typing, saving, editing again -> Nothing should change User calls reformat function -> Reformat and reorder User edits flow -> XML gets changes programmatically and gets reformatted and reordered Maybe: User loses editor focus, changes tab/file or page -> auto-reformat

The order in the FF! Doc is as follows:

• Required attributes
• Order of the XSD

The order of the XSD is actually important because it is sorted by input/output rather than alphabetically.

The Flow also had namespaces in the XML. I don't care where they are shown (At top or bottom) as long as they are together and also in the order of the XSD.

I have implemented this. Now its ordered according to the xsd order.

[sonarqubecloud]

Quality Gate passed

Issues
4 New issues
0 Accepted issues

Measures
0 Security Hotspots
80.6% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[sonarqubecloud]

Quality Gate passed

Issues
4 New issues
0 Accepted issues

Measures
0 Security Hotspots
80.6% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud