Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 6 additions & 30 deletions src/main/frontend/app/routes/studio/context/element-hover-card.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -2,30 +2,21 @@ import type { ElementDetails } from '@frankframework/doc-library-core'
import { useFFDoc, useJavadocTransform } from '@frankframework/doc-library-react'
import { useEffect, useLayoutEffect, useRef, useState } from 'react'
import { createPortal } from 'react-dom'
import { useShortcut } from '~/hooks/use-shortcut'
import { frankdocChipStyle, getFirstLabelGroup } from '~/utils/flow-utils'
import ExternalLinkIcon from '../../../../icons/solar/External Link.svg?react'

interface ElementHoverCardProps {
anchorRect: DOMRect
element: ElementDetails
isLocked: boolean
onComplete?: () => void
onUnlock?: () => void
onEnter?: () => void
onLeave?: () => void
}

export default function ElementHoverCard({
anchorRect,
element,
onComplete,
onUnlock,
onEnter,
onLeave,
}: ElementHoverCardProps) {
export default function ElementHoverCard({ anchorRect, element, onUnlock, onEnter, onLeave }: ElementHoverCardProps) {
const ref = useRef<HTMLDivElement>(null)
const [position, setPosition] = useState<{ top: number; left: number }>({ top: 0, left: 0 })
const [fillWidth, setFillWidth] = useState(0)
const offset = 10 // distance between anchor and tooltip
const [labelGroup, label] = getFirstLabelGroup(element.labels)
const route = element.labels ? [labelGroup, label, element.name].join('/') : element.className
Expand All @@ -52,13 +43,6 @@ export default function ElementHoverCard({
setPosition({ top: clampedTop, left })
}, [anchorRect])

useEffect(() => {
const timeout = setTimeout(() => {
setFillWidth(100)
}, 50)
return () => clearTimeout(timeout)
}, [onComplete])

useEffect(() => {
function handleClickOutside(event: MouseEvent) {
if (!ref.current) return
Expand All @@ -71,6 +55,10 @@ export default function ElementHoverCard({
return () => document.removeEventListener('pointerdown', handleClickOutside, true)
}, [onUnlock])

useShortcut({
'studio.close-palette-card': () => onUnlock?.(),
})

return createPortal(
<div
ref={ref}
Expand All @@ -86,18 +74,6 @@ export default function ElementHoverCard({
onMouseEnter={onEnter}
onMouseLeave={onLeave}
>
<div className="bg-backdrop h-1 w-full shrink-0 overflow-hidden rounded-t-md">
<div
className="bg-foreground-active h-full transition-all duration-1000 ease-linear"
style={{ width: `${fillWidth}%` }}
onTransitionEnd={() => {
if (fillWidth === 100) {
onComplete?.()
}
}}
/>
</div>

<div className="flex-1 overflow-x-auto overflow-y-auto px-4 pt-3 pb-4">
{/* Header: left = breadcrumb + name; right = FrankDoc link fills the full height */}
<div className="mb-3 flex items-stretch justify-between gap-3">
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -152,8 +152,6 @@ export default function SortedElements({ type, items, onDragStart, searchTerm }:
key={(lockedElement ?? hoveredElement)!.name}
anchorRect={hoveredRect!}
element={lockedElement ?? hoveredElement!}
isLocked={!!lockedElement}
onComplete={() => setLockedElement(hoveredElement)}
onUnlock={() => {
setLockedElement(null)
setHoveredElement(null)
Expand Down
6 changes: 6 additions & 0 deletions src/main/frontend/app/stores/shortcut-store.ts
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,12 @@ export const ALL_SHORTCUTS: Omit<ShortcutDefinition, 'handler'>[] = [
{ id: 'studio.group', label: 'Group Selection', scope: 'studio', key: 'g' },
{ id: 'studio.ungroup', label: 'Ungroup Selection', scope: 'studio', key: 'g', modifiers: { shift: true } },
{ id: 'studio.save', label: 'Save Changes', scope: 'studio', key: 's', modifiers: { cmdOrCtrl: true } },
{
id: 'studio.close-palette-card',
label: 'Close Palette Description',
scope: 'studio',
key: 'escape',
},
{
id: 'studio.close-context',
label: 'Discard / Close Edit Panel',
Expand Down
Loading