Skip to content

Refactor input components and update styles across various modals and and components#493

Open
stijnpotters1 wants to merge 13 commits into
masterfrom
fix/general-styling
Open

Refactor input components and update styles across various modals and and components#493
stijnpotters1 wants to merge 13 commits into
masterfrom
fix/general-styling

Conversation

@stijnpotters1
Copy link
Copy Markdown
Contributor

@stijnpotters1 stijnpotters1 commented May 20, 2026

I think its better to checkout in the branch and check the changes
Keeps themes better into account

@philipsens
Copy link
Copy Markdown
Member

philipsens commented May 26, 2026

I think these hover things should be the same. I think everything that is inconsistent kind of takes me out of focus.

Screencast.From.2026-05-26.13-14-23.mp4

No hover transitions. What kind of button is the open in studio button?

Screencast.From.2026-05-26.13-18-48.mp4

This one has no hover so it is inconsistent
image

Hovering over active nav button should not change
image

This is a pretty good example of how different buttons act very different. I'm not saying there shouldn't be different buttons, but they should feel coherent.
We need to look at all different "types" of buttons and create components for them, and use them consistently.

Screencast.From.2026-05-26.13-22-47.mp4

Transition
image

This is not the button component?
image

Dropdowns:
image

image (that one should be combo box honestly) image

I'm not sure if I got to see everything with my current setup. Overall there is still a lot that can get cleaned up.

@stijnpotters1
Copy link
Copy Markdown
Contributor Author

@philipsens Perhaps its a good idea to go through the application one more time together to find inconsistencies?

@philipsens
Copy link
Copy Markdown
Member

Sure!

@stijnpotters1 stijnpotters1 mentioned this pull request May 26, 2026
@stijnpotters1 stijnpotters1 linked an issue May 26, 2026 that may be closed by this pull request
@stijnpotters1 stijnpotters1 force-pushed the fix/general-styling branch from 4e008f4 to 881855d Compare May 26, 2026 16:02
@sonarqubecloud
Copy link
Copy Markdown

@Matthbo
Copy link
Copy Markdown
Member

Matthbo commented May 26, 2026

Ill do a review once @philipsens is okay with the changes in this PR, it's gotten quite big from the looks of it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tab shadow General Landingpage / Configuration Selection

3 participants