Improve frontend API error handling#494
Merged
Matthbo merged 8 commits intoMay 27, 2026
Merged
Conversation
Matthbo
force-pushed
the
issue/479-frontend-error-handling-of-api-services
branch
from
e1e2b38 to
8d15f10
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR centralizes frontend API error/warning reporting by introducing a small logging helper that shows user-friendly toasts while still logging full errors to the browser console. It also refactors apiFetch / ApiError and updates multiple call sites to use the new logging approach.
Changes:
- Add
logApiError/logApiWarninghelper and replace variousconsole.error/showErrorToastFromusages across the UI. - Update
ApiError/backend error parsing and adjust related consumers (e.g. DirectoryPicker, ProjectLanding). - Tweak toast durations and clean up a handful of warning/toast messages.
Reviewed changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/main/frontend/app/utils/logger.ts | Adds centralized toast+console logging helpers for API warnings/errors. |
| src/main/frontend/app/utils/api.ts | Refactors ApiError shape and apiFetch header/body handling and response parsing. |
| src/main/frontend/app/routes/studio/context/sorted-elements.tsx | Consolidates warning toast + console message for failed drop action. |
| src/main/frontend/app/routes/studio/canvas/flow.tsx | Uses logApiError for save/load flow failures. |
| src/main/frontend/app/routes/projectlanding/project-landing.tsx | Refactors app-info fetch flow and logs discovery errors via logApiError. |
| src/main/frontend/app/routes/editor/editor.tsx | Switches save/load/reformat error handling to logApiError. |
| src/main/frontend/app/routes/datamapper/root.tsx | Minor console + toast message cleanup for debug button. |
| src/main/frontend/app/routes/datamapper/property-list.tsx | Comment/message cleanup and minor refactors for readability. |
| src/main/frontend/app/providers/frankconfig-xsd-provider.tsx | Uses logApiWarning when XSD fetch fails. |
| src/main/frontend/app/components/toast.tsx | Adjusts default toast durations; removes showErrorToastFrom. |
| src/main/frontend/app/components/git/git-panel.tsx | Switches git API failure handling to logApiError. |
| src/main/frontend/app/components/file-structure/use-studio-context-menu.ts | Switches context menu error handling to logApiError. |
| src/main/frontend/app/components/file-structure/use-file-tree-context-menu.ts | Switches context menu error handling to logApiError. |
| src/main/frontend/app/components/file-structure/studio-files-data-provider.ts | Uses logApiError when loading directories fails; simplifies warn messages. |
| src/main/frontend/app/components/file-structure/editor-data-provider.ts | Uses logApiWarning for file tree/directory load failures; simplifies warn messages. |
| src/main/frontend/app/components/directory-picker/directory-picker.tsx | Updates forbidden-access handling to use ApiError.httpCode. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
stijnpotters1
requested changes
May 26, 2026
…ervices # Conflicts: # src/main/frontend/app/components/file-structure/studio-files-data-provider.ts
stijnpotters1
left a comment
stijnpotters1
left a comment
Contributor
There was a problem hiding this comment.
'logApiWarning' is defined but never used. Allowed unused vars must match
in 'src/main/frontend/app/components/file-structure/editor-data-provider.ts'
|
stijnpotters1
approved these changes
May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Toasts based on API errors/warnings are now more user friendly while outputting the stacktrace to the browser console
Tiny cleanup where I found improvements to be made