Skip to content

Add folder creation functionality to directory picker#496

Merged
stijnpotters1 merged 3 commits into
masterfrom
feat/add-create-folder
May 26, 2026
Merged

Add folder creation functionality to directory picker#496
stijnpotters1 merged 3 commits into
masterfrom
feat/add-create-folder

Conversation

@stijnpotters1
Copy link
Copy Markdown
Contributor

image image image image

@stijnpotters1 stijnpotters1 self-assigned this May 26, 2026
@philipsens
Copy link
Copy Markdown
Member

Looks very nice!

Copy link
Copy Markdown
Member

@Matthbo Matthbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks sound in terms of code, is this the correct design to implement though?

@stijnpotters1
Copy link
Copy Markdown
Contributor Author

This looks sound in terms of code, is this the correct design to implement though?

What do you mean?

@stijnpotters1 stijnpotters1 requested a review from Matthbo May 26, 2026 11:37
@Matthbo
Copy link
Copy Markdown
Member

Matthbo commented May 26, 2026

This looks sound in terms of code, is this the correct design to implement though?

What do you mean?

The border doesn't really seem to fit the design of the page, the buttons feel weird.
What happens if you create a new folder but don't select it, seems to me that creating a new folder means it should be opened at the time of creation instead of having to reselect it

@philipsens
Copy link
Copy Markdown
Member

I do kind of agree with Vivy. This is a new design element that isn't getting used in other places. It is better to keep things consistent en use a popup here too, like what a new folder in the editor does.

@stijnpotters1
Copy link
Copy Markdown
Contributor Author

stijnpotters1 commented May 26, 2026

I do kind of agree with Vivy. This is a new design element that isn't getting used in other places. It is better to keep things consistent en use a popup here too, like what a new folder in the editor does.

But in this case you get a double popup modal, is this what we want?
It will look like this:
image

@philipsens
Copy link
Copy Markdown
Member

But in this case you get a double popup modal, is this what we want? It will look like this

Ah, yes now it looks the same as in the editor. As a last piece of feedback would be to change 'OK' to 'Create'.

@stijnpotters1
Copy link
Copy Markdown
Contributor Author

image

@sonarqubecloud
Copy link
Copy Markdown

@stijnpotters1 stijnpotters1 merged commit ac067af into master May 26, 2026
5 checks passed
@stijnpotters1 stijnpotters1 deleted the feat/add-create-folder branch May 26, 2026 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make it possible to create folders in the new configuration dialog - or - use the OS file dialog

3 participants