Skip to content

Implement file watching functionality in filesystem and directory picker#497

Merged
stijnpotters1 merged 11 commits into
masterfrom
feat/add-file-watching
May 27, 2026
Merged

Implement file watching functionality in filesystem and directory picker#497
stijnpotters1 merged 11 commits into
masterfrom
feat/add-file-watching

Conversation

@stijnpotters1
Copy link
Copy Markdown
Contributor

@stijnpotters1 stijnpotters1 commented May 26, 2026

Before adding a file in the original file explorer
image
After adding file in the file explorer its immediately added, even though the directory picker stayed open
image

Also in the editor and studio file tree
image

@stijnpotters1 stijnpotters1 self-assigned this May 26, 2026
Copy link
Copy Markdown
Member

@Matthbo Matthbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lots of undefined's where null's should be used
Making a poller for file changes from the frontend to the backend doesn't seem optimal, websockets or an equivalent should be used to push file changes to the client instead

@stijnpotters1
Copy link
Copy Markdown
Contributor Author

Lots of undefined's where null's should be used Making a poller for file changes from the frontend to the backend doesn't seem optimal, websockets or an equivalent should be used to push file changes to the client instead

@Matthbo The current implementation uses SSE (EventSource + Spring's SseEmitter), which is a server push mechanism. The server pushes file change events to the client. It's not polling.

@stijnpotters1 stijnpotters1 requested a review from Matthbo May 26, 2026 12:59
@Matthbo
Copy link
Copy Markdown
Member

Matthbo commented May 26, 2026

Lots of undefined's where null's should be used Making a poller for file changes from the frontend to the backend doesn't seem optimal, websockets or an equivalent should be used to push file changes to the client instead

@Matthbo The current implementation uses SSE (EventSource + Spring's SseEmitter), which is a server push mechanism. The server pushes file change events to the client. It's not polling.

Gotcha, seems like I misinterpreted
I've never used EventSource before so this is really awesome to see :D

Copy link
Copy Markdown
Member

@Matthbo Matthbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also notice the sonar warnings

Comment thread src/main/java/org/frankframework/flow/file/FileWatcherService.java
@stijnpotters1 stijnpotters1 requested a review from Matthbo May 26, 2026 15:03
@stijnpotters1 stijnpotters1 requested a review from Matthbo May 26, 2026 15:51
@sonarqubecloud
Copy link
Copy Markdown

@stijnpotters1 stijnpotters1 merged commit 15eb36a into master May 27, 2026
5 checks passed
@stijnpotters1 stijnpotters1 deleted the feat/add-file-watching branch May 27, 2026 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Files created outside of the filetree context do not trigger a refresh of the filetree and are not shown

2 participants