Skip to content

Refactored to original monaco editor instead of the /react version#575

Merged
stijnpotters1 merged 2 commits into
masterfrom
hotfix/broken-monaco-editor
Jun 29, 2026
Merged

Refactored to original monaco editor instead of the /react version#575
stijnpotters1 merged 2 commits into
masterfrom
hotfix/broken-monaco-editor

Conversation

@stijnpotters1

Copy link
Copy Markdown
Contributor

Now the monaco editor is bundled instead of loading the monaco editor from a CDN

@stijnpotters1 stijnpotters1 requested a review from Matthbo June 24, 2026 17:31
@stijnpotters1 stijnpotters1 self-assigned this Jun 24, 2026
@stijnpotters1 stijnpotters1 linked an issue Jun 24, 2026 that may be closed by this pull request
@Matthbo

Matthbo commented Jun 26, 2026

Copy link
Copy Markdown
Member

There still seems to be something that adds a monaco loader script to the dom in order to load the monace editor, instead of using the bundled assests
image

If this is the monaco bundled loader doing that it would be a little disappointing, but in case it isn't could you look for the source of this and preferably bundle the loader instead of doing any cdn work?

…t version so the monaco editor is bundled instead of loading the monaco editor from a CDN
@stijnpotters1 stijnpotters1 force-pushed the hotfix/broken-monaco-editor branch from cac4078 to 09e02a3 Compare June 29, 2026 13:20
@sonarqubecloud

Copy link
Copy Markdown

@stijnpotters1 stijnpotters1 merged commit 527872e into master Jun 29, 2026
5 checks passed
@stijnpotters1 stijnpotters1 deleted the hotfix/broken-monaco-editor branch June 29, 2026 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Monaco editor infinite loading

2 participants