Skip to content

Updated flow store methods to enhance node management and clear history #589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
stijnpotters1 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Updated flow store methods to enhance node management and clear history #589

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/main/frontend/app/routes/studio/canvas/flow.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -338,7 +338,7 @@
logApiError('Failed to save XML', error as Error)
setIdle()
}
}, [])

Check warning on line 341 in src/main/frontend/app/routes/studio/canvas/flow.tsx

View workflow job for this annotation

GitHub Actions / Build & Run All Tests 

React Hook useCallback has missing dependencies: 'setIdle', 'setSaved', and 'setSaving'. Either include them or remove the dependency array

const autosaveEnabled = useSettingsStore((s) => s.general.autoSave.enabled)
const autosaveDelay = useSettingsStore((s) => s.general.autoSave.delayMs)
Expand Down Expand Up @@ -691,7 +691,7 @@
node.type === 'frankNode' || node.type === 'exitNode' ? { ...node, position: { x: 0, y: 0 } } : node,
)
const laidOutNodes = layoutGraph(nodesWithResetPositions, flowStore.edges, 'LR')
flowStore.setNodes(laidOutNodes)
flowStore.setNodesWithoutHistory(laidOutNodes)

if (pendingSelection) {
applySelectionToNodes(pendingSelection)
Expand All @@ -702,6 +702,9 @@
reactFlowRef.current?.setViewport(freshViewport)
})
}

flowStore.setHistory([])
flowStore.setFuture([])
}, [
nodesInitialized,
relayoutNonce,
Expand Down Expand Up @@ -1220,7 +1223,7 @@
setParentId(null)
}

function addNodeAtPosition(

Check warning on line 1226 in src/main/frontend/app/routes/studio/canvas/flow.tsx

View workflow job for this annotation

GitHub Actions / Build & Run All Tests 

Refactor this function to reduce its Cognitive Complexity from 17 to the 15 allowed
position: { x: number; y: number },
elementName: string,
sourceInfo?: { nodeId: string | null; handleId: string | null; handleType: 'source' | 'target' | null },
Expand Down
Loading