fix: turning off model cache now correctly keeps it untouched

Author: frankroeder

lua/parrot/chat_handler.lua

@@ -1243,8 +1243,9 @@ function ChatHandler:model(params)
   local has_telescope, telescope = pcall(require, "telescope")
 
   -- Get models with caching support
+  -- Note: model_cache_expiry_hours = 0 means "use cached models forever, don't fetch new"
   local models
-  if prov:online_model_fetching() and self.options.model_cache_expiry_hours > 0 then
+  if prov:online_model_fetching() and self.options.model_cache_expiry_hours >= 0 then
     local spinner = self.options.enable_spinner and Spinner:new(self.options.spinner_type) or nil
     models = prov:get_available_models_cached(self.state, self.options.model_cache_expiry_hours, spinner)
   else

lua/parrot/config.lua

@@ -231,7 +231,7 @@ local defaults = {
       -- Refetch models (similar to setup logic, only for available providers)
       for _, prov_name in ipairs(providers_to_reload) do
         local _prov = require("parrot.provider").init_provider(vim.tbl_deep_extend("force", {name = prov_name}, parrot.providers[prov_name]))
-        if _prov:online_model_fetching() and parrot.options.model_cache_expiry_hours > 0 then
+        if _prov:online_model_fetching() and parrot.options.model_cache_expiry_hours >= 0 then
           local endpoint_hash = require("parrot.utils").generate_endpoint_hash(_prov)
           parrot.logger.info("Reloading model cache for " .. prov_name)
           local fresh_models = _prov:get_available_models_cached(state, parrot.options.model_cache_expiry_hours, spinner)
@@ -341,7 +341,8 @@ function M.setup(opts)
     local _prov = init_provider(provider_config)
 
     -- Use cached model fetching if provider has model_endpoint
-    if _prov:online_model_fetching() and M.options.model_cache_expiry_hours > 0 then
+    -- Note: model_cache_expiry_hours = 0 means "use cached models forever, don't fetch new"
+    if _prov:online_model_fetching() and M.options.model_cache_expiry_hours >= 0 then
       -- Check cache validity for this specific provider
       local endpoint_hash = utils.generate_endpoint_hash(_prov)
       local needs_update = not temp_state:is_cache_valid(prov_name, M.options.model_cache_expiry_hours, endpoint_hash)

lua/parrot/provider/multi_provider.lua

@@ -491,20 +491,22 @@ end
 function MultiProvider:get_available_models_cached(state, cache_expiry_hours, spinner)
   -- Only use caching if model_endpoint is configured
   -- otherwise return fallback models
-  if not self:online_model_fetching() and cache_expiry_hours == 0 then
+  if not self:online_model_fetching() then
     return self.models
   end
 
   -- Generate endpoint hash for cache validation
   local endpoint_hash = utils.generate_endpoint_hash(self)
 
   -- Try to get from cache first
+  -- Note: cache_expiry_hours = 0 means "never expire, use cached models forever"
   local cached_models = state:get_cached_models(self.name, cache_expiry_hours, endpoint_hash)
   if cached_models then
     return cached_models
   end
 
-  -- Cache miss or expired - fetch fresh models
+  -- Cache miss or expired - fetch fresh models only if expiry > 0
+  -- When cache_expiry_hours = 0, only fetch if no cache exists (first time setup)
   if spinner then
     spinner:start("Fetching models for " .. self.name .. "...")
   end

lua/parrot/state.lua

@@ -229,7 +229,8 @@ function State:get_cached_models(provider, cache_expiry_hours, endpoint_hash)
   local expiry_seconds = cache_expiry_hours * 3600
 
   -- Check if cache is expired
-  if (now - cached.timestamp) > expiry_seconds then
+  -- Note: cache_expiry_hours = 0 means "never expire" (keep cached models forever)
+  if cache_expiry_hours > 0 and (now - cached.timestamp) > expiry_seconds then
     return nil
   end