fix: minor fixes in report print formats#55151
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (9)
✅ Files skipped from review due to trivial changes (1)
📝 WalkthroughWalkthroughThis PR updates embedded HTML/CSS templates for multiple accounts print formats (AP/AR, General Ledger, Trial Balance, Balance Sheet, Cash Flow, P&L) to standardize typography, table border rendering, header corner styling, report-meta layout, and add a Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
erpnext/accounts/print_format/accounts_receivable_standard/accounts_receivable_standard.json (1)
11-11: 💤 Low valueMinor:
.text-muted!importantusage is inconsistent across print formats.In this file (and
accounts_payable_standard,general_ledger_standard,balance_sheet_standard,cash_flow_statement_standard,p&l_statement_standard).text-mutedis defined ascolor:#7c7c7c;, while inaccounts_payable_summary_standardandaccounts_receivable_summary_standardit iscolor:#7c7c7c!important;. Consider aligning on one form for consistency since all of these print formats are introduced together.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@erpnext/accounts/print_format/accounts_receivable_standard/accounts_receivable_standard.json` at line 11, The .text-muted CSS rule is inconsistent across print formats; standardize to the non-!important variant by keeping the .text-muted declaration as "color: `#7c7c7c`;" (no !important) in the html payload (the "html" key) where .text-muted is defined and remove the "!important" from the .text-muted rule in the summary print-format files that currently include it so all formats use the same ".text-muted" class.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In
`@erpnext/accounts/print_format/accounts_receivable_standard/accounts_receivable_standard.json`:
- Line 11: The .text-muted CSS rule is inconsistent across print formats;
standardize to the non-!important variant by keeping the .text-muted declaration
as "color: `#7c7c7c`;" (no !important) in the html payload (the "html" key) where
.text-muted is defined and remove the "!important" from the .text-muted rule in
the summary print-format files that currently include it so all formats use the
same ".text-muted" class.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yml
Review profile: CHILL
Plan: Pro
Run ID: f9c51f52-8a8c-4e8c-9dea-ea56a51484e3
📒 Files selected for processing (9)
erpnext/accounts/print_format/accounts_payable_standard/accounts_payable_standard.jsonerpnext/accounts/print_format/accounts_payable_summary_standard/accounts_payable_summary_standard.jsonerpnext/accounts/print_format/accounts_receivable_standard/accounts_receivable_standard.jsonerpnext/accounts/print_format/accounts_receivable_summary_standard/accounts_receivable_summary_standard.jsonerpnext/accounts/print_format/balance_sheet_standard/balance_sheet_standard.jsonerpnext/accounts/print_format/cash_flow_statement_standard/cash_flow_statement_standard.jsonerpnext/accounts/print_format/general_ledger_standard/general_ledger_standard.jsonerpnext/accounts/print_format/p&l_statement_standard/p&l_statement_standard.jsonerpnext/accounts/print_format/trial_balance_standard/trial_balance_standard.json
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #55151 +/- ##
===========================================
+ Coverage 79.83% 79.91% +0.07%
===========================================
Files 1169 1176 +7
Lines 128027 129019 +992
===========================================
+ Hits 102210 103104 +894
- Misses 25817 25915 +98 🚀 New features to boost your workflow:
|
No description provided.