Skip to content

fix: minor fixes in report print formats#55151

Open
Shllokkk wants to merge 2 commits into
frappe:developfrom
Shllokkk:report-print-format
Open

fix: minor fixes in report print formats#55151
Shllokkk wants to merge 2 commits into
frappe:developfrom
Shllokkk:report-print-format

Conversation

@Shllokkk
Copy link
Copy Markdown
Contributor

No description provided.

@Shllokkk Shllokkk requested a review from ruthra-kumar as a code owner May 21, 2026 13:50
@Shllokkk Shllokkk assigned Shllokkk and khushi8112 and unassigned Shllokkk May 21, 2026
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 21, 2026

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro

Run ID: cc593f3a-45db-402d-b1e7-2a6f5e460567

📥 Commits

Reviewing files that changed from the base of the PR and between 3f8c5f0 and b35d072.

📒 Files selected for processing (9)
  • erpnext/accounts/report/accounts_payable/accounts_payable.json
  • erpnext/accounts/report/accounts_payable_summary/accounts_payable_summary.json
  • erpnext/accounts/report/accounts_receivable/accounts_receivable.json
  • erpnext/accounts/report/accounts_receivable_summary/accounts_receivable_summary.json
  • erpnext/accounts/report/balance_sheet/balance_sheet.json
  • erpnext/accounts/report/cash_flow/cash_flow.json
  • erpnext/accounts/report/general_ledger/general_ledger.json
  • erpnext/accounts/report/profit_and_loss_statement/profit_and_loss_statement.json
  • erpnext/accounts/report/trial_balance/trial_balance.json
✅ Files skipped from review due to trivial changes (1)
  • erpnext/accounts/report/balance_sheet/balance_sheet.json

📝 Walkthrough

Walkthrough

This PR updates embedded HTML/CSS templates for multiple accounts print formats (AP/AR, General Ledger, Trial Balance, Balance Sheet, Cash Flow, P&L) to standardize typography, table border rendering, header corner styling, report-meta layout, and add a .text-muted utility used by the “Printed on” footer. Several financial statement templates also remove the conditional blank-row class assignment. Separately, multiple report JSON definitions were refreshed to include explicit configuration fields (columns, filters, timeout, prepared_report, default_print_format) and remove apply_user_permissions; timestamps and idx values were updated.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Possibly related PRs

  • frappe/erpnext#53822: Overlapping Accounts Receivable print-format HTML/CSS template changes.
  • frappe/erpnext#53762: Related General Ledger print-format template updates.
  • frappe/erpnext#53934: Related financial-statement print-format template refinements (Balance Sheet, Cash Flow, P&L, Trial Balance).

Suggested labels

needs-tests, backport version-16-hotfix

Suggested reviewers

  • khushi8112
  • ruthra-kumar
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive No pull request description was provided by the author, making it impossible to assess alignment with the changeset. Add a description explaining the purpose and scope of the print format fixes to help reviewers understand the changes.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the changes as minor fixes to report print formats across multiple accounting reports.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
erpnext/accounts/print_format/accounts_receivable_standard/accounts_receivable_standard.json (1)

11-11: 💤 Low value

Minor: .text-muted !important usage is inconsistent across print formats.

In this file (and accounts_payable_standard, general_ledger_standard, balance_sheet_standard, cash_flow_statement_standard, p&l_statement_standard) .text-muted is defined as color: #7c7c7c;, while in accounts_payable_summary_standard and accounts_receivable_summary_standard it is color: #7c7c7c !important;. Consider aligning on one form for consistency since all of these print formats are introduced together.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In
`@erpnext/accounts/print_format/accounts_receivable_standard/accounts_receivable_standard.json`
at line 11, The .text-muted CSS rule is inconsistent across print formats;
standardize to the non-!important variant by keeping the .text-muted declaration
as "color: `#7c7c7c`;" (no !important) in the html payload (the "html" key) where
.text-muted is defined and remove the "!important" from the .text-muted rule in
the summary print-format files that currently include it so all formats use the
same ".text-muted" class.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In
`@erpnext/accounts/print_format/accounts_receivable_standard/accounts_receivable_standard.json`:
- Line 11: The .text-muted CSS rule is inconsistent across print formats;
standardize to the non-!important variant by keeping the .text-muted declaration
as "color: `#7c7c7c`;" (no !important) in the html payload (the "html" key) where
.text-muted is defined and remove the "!important" from the .text-muted rule in
the summary print-format files that currently include it so all formats use the
same ".text-muted" class.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro

Run ID: f9c51f52-8a8c-4e8c-9dea-ea56a51484e3

📥 Commits

Reviewing files that changed from the base of the PR and between 70b9f54 and 3f8c5f0.

📒 Files selected for processing (9)
  • erpnext/accounts/print_format/accounts_payable_standard/accounts_payable_standard.json
  • erpnext/accounts/print_format/accounts_payable_summary_standard/accounts_payable_summary_standard.json
  • erpnext/accounts/print_format/accounts_receivable_standard/accounts_receivable_standard.json
  • erpnext/accounts/print_format/accounts_receivable_summary_standard/accounts_receivable_summary_standard.json
  • erpnext/accounts/print_format/balance_sheet_standard/balance_sheet_standard.json
  • erpnext/accounts/print_format/cash_flow_statement_standard/cash_flow_statement_standard.json
  • erpnext/accounts/print_format/general_ledger_standard/general_ledger_standard.json
  • erpnext/accounts/print_format/p&l_statement_standard/p&l_statement_standard.json
  • erpnext/accounts/print_format/trial_balance_standard/trial_balance_standard.json

@codecov
Copy link
Copy Markdown

codecov Bot commented May 21, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.91%. Comparing base (eba58b2) to head (b35d072).
⚠️ Report is 86 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #55151      +/-   ##
===========================================
+ Coverage    79.83%   79.91%   +0.07%     
===========================================
  Files         1169     1176       +7     
  Lines       128027   129019     +992     
===========================================
+ Hits        102210   103104     +894     
- Misses       25817    25915      +98     

see 65 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@khushi8112 khushi8112 requested review from khushi8112 and removed request for ruthra-kumar May 21, 2026 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants