Skip to content

Commit fd54077

Browse files
Removed unnecessary object
1 parent bb6f264 commit fd54077

4 files changed

Lines changed: 47 additions & 43 deletions

File tree

README.md

Lines changed: 15 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -94,13 +94,11 @@ params = {
9494
ship_zip_code: '33602',
9595
ship_country: 'US',
9696
};
97-
flp.validate(params, flpResults);
98-
99-
function flpResults(err, res, data) {
100-
if (!err && res.statusCode == 200) {
97+
flp.validate(params, (err, data) => {
98+
if (!err) {
10199
console.log(data);
102100
}
103-
}
101+
});
104102
```
105103

106104

@@ -123,13 +121,11 @@ params = {
123121
id: '20170906MXFHSTRF',
124122
id_type: 'fraudlabspro_id',
125123
};
126-
flp.getTransaction(params, flpResults);
127-
128-
function flpResults(err, res, data) {
129-
if (!err && res.statusCode == 200) {
124+
flp.getTransaction(params, (err, data) => {
125+
if (!err) {
130126
console.log(data);
131127
}
132-
}
128+
});
133129
```
134130

135131

@@ -154,13 +150,11 @@ params = {
154150
action: 'APPROVE',
155151
note: 'This customer made a valid purchase before.',
156152
};
157-
flp.feedback(params, flpResults);
158-
159-
function flpResults(err, res, data) {
160-
if (!err && res.statusCode == 200) {
153+
flp.feedback(params, (err, data) => {
154+
if (!err) {
161155
console.log(data);
162156
}
163-
}
157+
});
164158
```
165159

166160

@@ -192,13 +186,11 @@ params = {
192186
otp_timeout: 3600,
193187
country_code: 'US',
194188
};
195-
sms.sendSMS(params, flpResults);
196-
197-
function flpResults(err, res, data) {
198-
if (!err && res.statusCode == 200) {
189+
sms.sendSMS(params, (err, data) => {
190+
if (!err) {
199191
console.log(data);
200192
}
201-
}
193+
});
202194
```
203195

204196

@@ -221,11 +213,9 @@ params = {
221213
tran_id: 'UNIQUE_TRANS_ID',
222214
otp: 'OTP_RECEIVED',
223215
};
224-
sms.verifyOTP(params, flpResults);
225-
226-
function flpResults(err, res, data) {
227-
if (!err && res.statusCode == 200) {
216+
sms.verifyOTP(params, (err, data) => {
217+
if (!err) {
228218
console.log(data);
229219
}
230-
}
220+
});
231221
```

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "fraudlabspro-nodejs",
3-
"version": "2.0.0",
3+
"version": "2.1.0",
44
"description": "FraudLabs Pro Node.js module enables users to easily implement fraud detection feature using the FraudLabs Pro API.",
55
"keywords": ["fraud prevention", "fraud detection", "fraud checker", "fraudlabs pro", "fraudlabspro", "fraud protection"],
66
"homepage": "https://github.com/fraudlabspro/fraudlabspro-nodejs",

src/fraudlabspro.js

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
var https = require('https');
22
var crypto = require('crypto');
3-
var VERSION = '2.0.0';
3+
var VERSION = '2.1.0';
44
var SOURCE = 'FraudLabsPro Node.js SDK';
55
var FORMAT = 'json';
66

@@ -136,7 +136,7 @@ class FraudValidation {
136136
let req = https.request(options, function (res) {
137137
res.on('data', (chunk) => (d = d + chunk));
138138
res.on('end', function () {
139-
callback(null, res, JSON.parse(d));
139+
callback(null, JSON.parse(d));
140140
});
141141
});
142142

@@ -184,7 +184,7 @@ class FraudValidation {
184184
let req = https.request(options, function (res) {
185185
res.on('data', (chunk) => (d = d + chunk));
186186
res.on('end', function () {
187-
callback(null, res, JSON.parse(d));
187+
callback(null, JSON.parse(d));
188188
});
189189
});
190190

@@ -220,7 +220,7 @@ class FraudValidation {
220220
let req = https.get(urlStr, function (res) {
221221
res.on('data', (chunk) => (d = d + chunk));
222222
res.on('end', function () {
223-
callback(null, res, JSON.parse(d));
223+
callback(null, JSON.parse(d));
224224
});
225225
});
226226

@@ -275,7 +275,7 @@ class SMSVerification {
275275
let req = https.request(options, function (res) {
276276
res.on('data', (chunk) => (d = d + chunk));
277277
res.on('end', function () {
278-
callback(null, res, JSON.parse(d));
278+
callback(null, JSON.parse(d));
279279
});
280280
});
281281

@@ -322,7 +322,7 @@ class SMSVerification {
322322
let req = https.request(options, function (res) {
323323
res.on('data', (chunk) => (d = d + chunk));
324324
res.on('end', function () {
325-
callback(null, res, JSON.parse(d));
325+
callback(null, JSON.parse(d));
326326
});
327327
});
328328

src/test.js

Lines changed: 25 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -9,34 +9,48 @@
99
// params = {
1010
// ip: '8.8.8.8'
1111
// };
12-
// flp.validate(params, flpResults);
12+
// flp.validate(params, (err, data) => {
13+
// if (!err) {
14+
// console.log(data);
15+
// }
16+
// });
1317

1418
// params = {
1519
// id: '20210716AZ1ZIC',
1620
// action: 'REJECT',
1721
// };
18-
// flp.feedback(params, flpResults);
22+
// flp.feedback(params, (err, data) => {
23+
// if (!err) {
24+
// console.log(data);
25+
// }
26+
// });
1927

2028
// params = {
2129
// id: '20210716AZ1ZIC',
2230
// id_type: 'fraudlabspro_id',
2331
// };
24-
// flp.getTransaction(params, flpResults);
32+
// flp.getTransaction(params, (err, data) => {
33+
// if (!err) {
34+
// console.log(data);
35+
// }
36+
// });
2537

2638
// params = {
2739
// tel: '+1234567890',
2840
// mesg: 'Hello, your OTP is <otp>.',
2941
// };
30-
// sms.sendSMS(params, flpResults);
42+
// sms.sendSMS(params, (err, data) => {
43+
// if (!err) {
44+
// console.log(data);
45+
// }
46+
// });
3147

3248
// params = {
3349
// tran_id: 'fG8Ee2w88DBD3HjzBz0',
3450
// otp: '649114',
3551
// };
36-
// sms.verifyOTP(params, flpResults);
37-
38-
function flpResults(err, res, data) {
39-
if (!err && res.statusCode == 200) {
40-
console.log(data);
41-
}
42-
}
52+
// sms.verifyOTP(params, (err, data) => {
53+
// if (!err) {
54+
// console.log(data);
55+
// }
56+
// });

0 commit comments

Comments
 (0)