feat: Add macro with-gsl-check-success

Introduce a macro that checks the result of executing gsl functions.
If the result is not $gsl-success it raises an error.

This macro avoids duplication of code.

Author: frayaIzv

doc/source/gsl-common.rst

@@ -22,3 +22,5 @@ The GSL-COMMON module
    :value vec: An instance of :const:`<vector-double-float>`.
 
 .. macro:: with-c-double-array
+
+.. macro:: with-gsl-check-success

src/lib/dylan-gsl.lid

@@ -15,10 +15,10 @@ Files: library.dylan
        ffi/vector-and-matrices/block.dylan
        ffi/vector-and-matrices/module-vector.dylan
        ffi/vector-and-matrices/vector.dylan
-       gsl/common/module.dylan
-       gsl/common/common.dylan
        gsl/error/module.dylan
        gsl/error/error.dylan
+       gsl/common/module.dylan
+       gsl/common/common.dylan
        gsl/math/module.dylan
        gsl/math/math.dylan
        gsl/vector-and-matrices/module-vector.dylan

src/lib/gsl/common/common.dylan

@@ -35,3 +35,11 @@ define macro with-c-double-array
            ?body
          end }
 end macro;
+
+define macro with-gsl-check-success
+  { with-gsl-check-success () ?body:body end }
+    => { let status :: <integer> = ?body; 
+         if (status ~= $gsl-success) 
+           error(make(<gsl-error>, code: status))
+         end }
+end macro;

src/lib/gsl/common/module.dylan

@@ -6,6 +6,10 @@ License: See LICENSE in this distribution for details.
 
 define module gsl-common
 
+  use gsl-error,
+    export: { $gsl-success,
+              <gsl-error> };
+
   create
     <double-float?>,
     <vector-double-float>,
@@ -14,15 +18,15 @@ define module gsl-common
     <numeric-sequence>;
 
   create
-    with-c-double-array;
+    with-c-double-array,
+    with-gsl-check-success;
 
 end module;
 
 define module gsl-common-impl
 
   use common-dylan;
   use c-ffi;
-
   use gsl-common;
 
 end module;

src/lib/gsl/error/module.dylan

@@ -6,6 +6,9 @@ License: See License.txt in this distribution for details.
 
 define module gsl-error
 
+  use gsl-ffi-error,
+    export: { $gsl-success };
+
   create
     <gsl-error>,
     gsl-error-code,
@@ -53,8 +56,7 @@ define module gsl-error-impl
 
   use common-dylan;
   use c-ffi;
-  use gsl-ffi-error,
-    export: { $gsl-success };
+  use gsl-ffi-error;
 
   use gsl-error;
 

src/lib/gsl/module-running-statistics.dylan

@@ -44,9 +44,7 @@ define module gsl-running-statistics-impl
 
   use common-dylan;
   use c-ffi;
-  use gsl-error;
-  use gsl-error-impl,
-    import: { $gsl-success };
+  use gsl-common;
 
   use gsl-ffi-running-statistics,
     prefix: "ffi/";

src/lib/gsl/running-statistics.dylan

@@ -28,9 +28,8 @@ end;
 
 define function rstat-reset!
   (rstat :: <rstat>) => ()
-  let status = ffi/gsl-rstat-reset(rstat.%rstat-workspace);
-  if (status ~= $gsl-success)
-    error(make(<gsl-error>, code: status))
+  with-gsl-check-success ()
+    ffi/gsl-rstat-reset(rstat.%rstat-workspace)
   end
 end;
 
@@ -45,9 +44,8 @@ define generic rstat-add!
 define method rstat-add!
    (rstat :: <rstat>, x :: <double-float>) 
 => ()
-  let status = ffi/gsl-rstat-add(rstat.%rstat-workspace, x);
-  if (status ~= $gsl-success)
-    error(make(<gsl-error>, code: status))
+  with-gsl-check-success ()
+    ffi/gsl-rstat-add(rstat.%rstat-workspace, x)
   end
 end;
 
@@ -144,9 +142,8 @@ define generic quantile-rstat-add!
 
 define method quantile-rstat-add!
   (quantile-rstat :: <quantile-rstat>, x :: <double-float>) => ()
-  let status = ffi/gsl-rstat-quantile-add(x, quantile-rstat.%quantile-rstat-workspace);
-  if (status ~= $gsl-success)
-    error(make(<gsl-error>, code: status))
+  with-gsl-check-success ()
+    ffi/gsl-rstat-quantile-add(x, quantile-rstat.%quantile-rstat-workspace)
   end
 end;