fix: Don't auto mark action notifications as read (fixes #329)

Author: freaktechnik

scripts/background.js

@@ -78,7 +78,9 @@ const openNotification = async (id) => {
         await browser.windows.update(tab.windowId, {
             focused: true
         });
-        await handler.markAsRead(id, false);
+        if(await handler.willAutoMarkAsRead(id)) {
+            await handler.markAsRead(id, false);
+        }
         const newCount = await manager.getCount();
         await updateBadge(newCount);
     }

scripts/github.js

@@ -312,7 +312,27 @@ class GitHub {
 
     async getNotificationDetails(notification) {
         if(notification.subject.type === "RepositoryInvitation" || notification.subject.type === "RepositoryVulnerabilityAlert" || !notification.subject.url) {
-            return notification.repository;
+            const details = { ...notification.repository };
+            switch(notification.subject.type) {
+            case "RepositoryInvitation":
+                details.html_url = `${notification.repository.html_url}/invitations`;
+                break;
+            case "RepositoryVulnerabilityAlert":
+                details.html_url = `${notification.repository.html_url}/network/dependencies`;
+                break;
+            case "RepositoryDependabotAlertsThread":
+                details.html_url = `${notification.repository.html_url}/security/dependabot`;
+                break;
+            case "CheckSuite":
+                details.html_url = `${notification.repository.html_url}/actions`;
+                details.willStayUnread = true;
+                break;
+            case "Discussion":
+                details.html_url = `${notification.repository.html_url}/discussions`;
+                break;
+            default:
+            }
+            return details;
         }
         const apiEndpoint = notification.subject.url;
         const response = await fetch(apiEndpoint, {

scripts/handler.js

@@ -288,13 +288,6 @@ class ClientHandler extends window.Storage {
         const notification = notifications.find((n) => n.id == id);
         //TODO get anchor to events after last_read_at for issues/prs
         if(notification) {
-            //TODO normalize html_url in subjectDetails
-            if(notification.subject.type === "RepositoryInvitation") {
-                return `${notification.repository.html_url}/invitations`;
-            }
-            if(notification.subject.type === "RepositoryVulnerabilityAlert") {
-                return `${notification.repository.html_url}/network/dependencies`;
-            }
             if(!notification.subjectDetails.html_url) {
                 return notification.repository.html_url;
             }
@@ -303,6 +296,18 @@ class ClientHandler extends window.Storage {
         return "";
     }
 
+    async willAutoMarkAsRead(id) {
+        if(this.client.shouldStayUnread) {
+            return false;
+        }
+        const notifications = await this._getNotifications();
+        const notification = notifications.find((n) => n.id == id);
+        if(notification?.willStayUnread) {
+            return false;
+        }
+        return true;
+    }
+
     async getCount() {
         const notifications = await this._getNotifications();
         return notifications.length;