Skip to content

Separate cache by architecture#263

Merged
pbrisbin merged 2 commits into
freckle:mainfrom
koterpillar:use-arch-in-cache-prefix
Aug 28, 2025
Merged

Separate cache by architecture#263
pbrisbin merged 2 commits into
freckle:mainfrom
koterpillar:use-arch-in-cache-prefix

Conversation

@koterpillar

Copy link
Copy Markdown
Contributor

Fixes #261

Note that existing caches will become invalid as a result of this change.

@koterpillar
koterpillar requested a review from a team as a code owner August 27, 2025 08:55
@koterpillar
koterpillar requested review from jason-lieb and removed request for a team August 27, 2025 08:55
@koterpillar

Copy link
Copy Markdown
Contributor Author

I could try to deduce the "default" architecture (likely x64 on Linux runners and arm64 on macOS runners, etc.) if we want to preserve (more of) existing caches.

@pbrisbin
pbrisbin requested review from pbrisbin and removed request for jason-lieb August 27, 2025 13:36

@pbrisbin pbrisbin left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, thanks. I guess the test failure was a hiccup, because it passed on retry (and we can ignore the asana one).

Two quick book-keeping things:

  1. Can you amend your commit to be fix: separate...?

    We don't require conventional commits generally, but it drives our automatic release, so formatting your commit this way will trigger a release with minor version bump.

  2. Please run yarn build and commit the updated dist/index.js

    Do this as its own commit please. We're trying to make this unnecessary, but for boring technical reasons we're not there yet.

Thanks!

Fixes #261

Note that existing caches will become invalid as a result of this
change.
@koterpillar

Copy link
Copy Markdown
Contributor Author

Done.

Note:

  • sed invocation in package.json does not work correctly with macOS version of sed.
  • yarn build changed all module identifiers, the build process might not be deterministic across different installs.

@pbrisbin

Copy link
Copy Markdown
Member

Thank you!

changed all module identifiers

😱 is that... OK?

I'm not a JavaScript expert, so I have no idea if this is an issue or how to solve it.

@koterpillar

Copy link
Copy Markdown
Contributor Author

That's not a functional change, see the diff - just some numbers reallocated. Feel free to re-run yarn build yourself if in doubt!

@pbrisbin
pbrisbin merged commit de2d332 into freckle:main Aug 28, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Separate cache by architecture

2 participants