Separate cache by architecture#263
Conversation
|
I could try to deduce the "default" architecture (likely |
pbrisbin
left a comment
There was a problem hiding this comment.
This looks good, thanks. I guess the test failure was a hiccup, because it passed on retry (and we can ignore the asana one).
Two quick book-keeping things:
-
Can you amend your commit to be
fix: separate...?We don't require conventional commits generally, but it drives our automatic release, so formatting your commit this way will trigger a release with minor version bump.
-
Please run
yarn buildand commit the updateddist/index.jsDo this as its own commit please. We're trying to make this unnecessary, but for boring technical reasons we're not there yet.
Thanks!
Fixes #261 Note that existing caches will become invalid as a result of this change.
|
Done. Note:
|
|
Thank you!
😱 is that... OK? I'm not a JavaScript expert, so I have no idea if this is an issue or how to solve it. |
|
That's not a functional change, see the diff - just some numbers reallocated. Feel free to re-run |
Fixes #261
Note that existing caches will become invalid as a result of this change.