Add tests for new tokenizer constant code

Author: fredden

phpunit.xml.dist

@@ -31,6 +31,9 @@
             <directory>./src/Standards/Squiz/Tests/</directory>
             <directory>./src/Standards/Zend/Tests/</directory>
         </testsuite>
+        <testsuite name="End2EndPhpt">
+            <directory suffix=".phpt">tests/EndToEndPhpt/</directory>
+        </testsuite>
     </testsuites>
 
     <groups>

tests/EndToEndPhpt/Util/Tokens/polyfillTokenizerConstants-collision-php.phpt

@@ -0,0 +1,18 @@
+--TEST--
+Detect when the value of a polyfilled PHP token collides with a value already used by an existing internal PHP token.
+--SKIPIF--
+<?php
+if (version_compare(PHP_VERSION, "8.4", ">=")) {
+    echo "skip because tokens used in this test already exist in PHP 8.4 so we cannot test polyfilling them", PHP_EOL;
+}
+--FILE--
+<?php
+define('T_PUBLIC_SET', T_STRING);
+require('src/Util/Tokens.php');
+--EXPECTF--
+Fatal error: Uncaught Exception: Externally polyfilled tokenizer constant value collision detected! T_PUBLIC_SET has the same value as T_STRING in %s:%d
+Stack trace:
+#0 %s(%d): PHP_CodeSniffer\Util\Tokens::polyfillTokenizerConstants()
+#1 Standard input code(%d): require('...')
+#2 {main}
+  thrown in %s on line %d

tests/EndToEndPhpt/Util/Tokens/polyfillTokenizerConstants-collision-user.phpt

@@ -0,0 +1,20 @@
+--TEST--
+Detect when two or more polyfilled PHP tokens have the same value.
+--SKIPIF--
+<?php
+if (version_compare(PHP_VERSION, "8.4", ">=")) {
+    echo "skip because tokens used in this test already exist in PHP 8.4 so we cannot test polyfilling them", PHP_EOL;
+}
+--FILE--
+<?php
+define('T_PRIVATE_SET', 10000);
+define('T_PROTECTED_SET', 10000);
+define('T_PUBLIC_SET', 10000);
+require('src/Util/Tokens.php');
+--EXPECTF--
+Fatal error: Uncaught Exception: Externally polyfilled tokenizer constant value collision detected! T_PROTECTED_SET has the same value as T_PRIVATE_SET in %s:%d
+Stack trace:
+#0 %s(%d): PHP_CodeSniffer\Util\Tokens::polyfillTokenizerConstants()
+#1 Standard input code(%d): require('...')
+#2 {main}
+  thrown in %s on line %d

tests/EndToEndPhpt/Util/Tokens/polyfillTokenizerConstants-number.phpt

@@ -0,0 +1,14 @@
+--TEST--
+Detect when an external party defines a PHP token polyfill with a number that we would have used.
+--SKIPIF--
+<?php
+if (version_compare(PHP_VERSION, "8.4", ">=")) {
+    echo "skip because tokens used in this test already exist in PHP 8.4 so we cannot test polyfilling them", PHP_EOL;
+}
+--FILE--
+<?php
+define('T_PUBLIC_SET', 135000);
+require('src/Util/Tokens.php');
+echo T_PRIVATE_SET, PHP_EOL; // ..0 is used, so this becomes ..1
+--EXPECT--
+135001

tests/EndToEndPhpt/Util/Tokens/polyfillTokenizerConstants-skip-names.phpt

@@ -0,0 +1,17 @@
+--TEST--
+Value collision with a non-tokenizer constant should not cause an error.
+--SKIPIF--
+<?php
+if (version_compare(PHP_VERSION, "8.4", ">=")) {
+    echo "skip because tokens used in this test already exist in PHP 8.4 so we cannot test polyfilling them", PHP_EOL;
+}
+--FILE--
+<?php
+// Using T_STRING as a value because that would be a collision (and throw) if the constant name looked like a tokenizer constant.
+define('T_', T_STRING); // Too short
+define('ONE', T_STRING); // First character is not 'T'
+define('TWO', T_STRING); // Second character is not '_'
+require('src/Util/Tokens.php');
+echo 'No conflicts', PHP_EOL;
+--EXPECT--
+No conflicts