Skip to content

[Repo Assist] fix: auto-format Dart files to fix CI formatting failures#82

Merged
fredeil merged 1 commit into
masterfrom
repo-assist/fix-issue-80-dart-format-eee8951073a3c5e2
Apr 20, 2026
Merged

[Repo Assist] fix: auto-format Dart files to fix CI formatting failures#82
fredeil merged 1 commit into
masterfrom
repo-assist/fix-issue-80-dart-format-eee8951073a3c5e2

Conversation

@github-actions
Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot commented Mar 2, 2026

🤖 This PR was created by Repo Assist, an automated AI assistant.

Summary

Runs dart format on the two files that were failing the CI format check, fixing the master branch CI failures described in issue #80.

Closes #80

Root Cause

The CI workflow added in PR #75 includes a dart format --output=none --set-exit-if-changed . step. Two files were merged without being auto-formatted first:

  • lib/email_validator.dart – function signature/parameter indentation style
  • test/email_validator_test.dart – general indentation and line-wrapping

Changes

All changes are pure whitespace / style reformatting — no logic, no behaviour, no API surface was touched. The specific reformatting in lib/email_validator.dart:

  • while condition split onto two lines (dart format style)
  • _skipDomain parameters formatted one-per-line with trailing comma
  • validate optional-parameter block formatted one-per-line with trailing comma

test/email_validator_test.dart receives similar one-per-line formatting for expect(...) calls and list literals.

Relationship to PR #79

PR #79 ([Repo Assist] chore: remove redundant import + document _skipIPv4Literal) also touches lib/email_validator.dart at different lines. Both PRs can land independently; whichever merges second may need a trivial rebase. Maintainers can choose the order.

Test Status

Build / tests: dart pub get is blocked by network firewall in this sandbox environment. Formatting changes are purely cosmetic and cannot affect test outcomes; the test suite passed on master before either file was formatted. CI will run on this PR once a maintainer triggers it (see note in #80 about github-actions[bot] PRs not auto-triggering CI).

Format check: verified locally — dart format --output=none --set-exit-if-changed . now exits 0.

Generated by Repo Assist

To install this workflow, run gh aw add githubnext/agentics/workflows/repo-assist.md@ee49512da7887942965ac0a0e48357106313c9dd. View source at https://github.com/githubnext/agentics/tree/ee49512da7887942965ac0a0e48357106313c9dd/workflows/repo-assist.md.

Warning

⚠️ Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

  • pub.dev

Run dart format on lib/email_validator.dart and test/email_validator_test.dart
to fix CI formatting check failures. Pure whitespace/style changes only;
no behaviour changes.

Closes #80

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@github-actions github-actions Bot added automation bug Something isn't working repo-assist labels Mar 2, 2026
@fredeil fredeil marked this pull request as ready for review March 3, 2026 08:45
Copilot AI review requested due to automatic review settings March 3, 2026 08:45
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes CI failures on the master branch (issue #80) by running dart format on the two files that were merged without being properly formatted before the CI format check was added in PR #75.

Changes:

  • Auto-formatted lib/email_validator.dart (parameter list indentation for _skipDomain and validate, while condition line split)
  • Auto-formatted test/email_validator_test.dart (trailing comma on list, one-per-line formatting for all expect(...) calls)

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
lib/email_validator.dart Reformatted while condition, _skipDomain parameter list, and validate optional-parameter block to dart format style
test/email_validator_test.dart Added trailing comma to validAddresses list and reformatted all expect(...) calls to one-argument-per-line dart format style

@fredeil fredeil merged commit baefa41 into master Apr 20, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automation bug Something isn't working repo-assist

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Repo Assist] CI failing on master: test file needs dart format

2 participants