[Repo Assist] fix: auto-format Dart files to fix CI formatting failures#82
Merged
fredeil merged 1 commit intoApr 20, 2026
Merged
Conversation
Run dart format on lib/email_validator.dart and test/email_validator_test.dart to fix CI formatting check failures. Pure whitespace/style changes only; no behaviour changes. Closes #80 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
8 tasks
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes CI failures on the master branch (issue #80) by running dart format on the two files that were merged without being properly formatted before the CI format check was added in PR #75.
Changes:
- Auto-formatted
lib/email_validator.dart(parameter list indentation for_skipDomainandvalidate,whilecondition line split) - Auto-formatted
test/email_validator_test.dart(trailing comma on list, one-per-line formatting for allexpect(...)calls)
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
lib/email_validator.dart |
Reformatted while condition, _skipDomain parameter list, and validate optional-parameter block to dart format style |
test/email_validator_test.dart |
Added trailing comma to validAddresses list and reformatted all expect(...) calls to one-argument-per-line dart format style |
fredeil
approved these changes
Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 This PR was created by Repo Assist, an automated AI assistant.
Summary
Runs
dart formaton the two files that were failing the CI format check, fixing the master branch CI failures described in issue #80.Closes #80
Root Cause
The CI workflow added in PR #75 includes a
dart format --output=none --set-exit-if-changed .step. Two files were merged without being auto-formatted first:lib/email_validator.dart– function signature/parameter indentation styletest/email_validator_test.dart– general indentation and line-wrappingChanges
All changes are pure whitespace / style reformatting — no logic, no behaviour, no API surface was touched. The specific reformatting in
lib/email_validator.dart:whilecondition split onto two lines (dart format style)_skipDomainparameters formatted one-per-line with trailing commavalidateoptional-parameter block formatted one-per-line with trailing commatest/email_validator_test.dartreceives similar one-per-line formatting forexpect(...)calls and list literals.Relationship to PR #79
PR #79 ([Repo Assist] chore: remove redundant import + document
_skipIPv4Literal) also toucheslib/email_validator.dartat different lines. Both PRs can land independently; whichever merges second may need a trivial rebase. Maintainers can choose the order.Test Status
Build / tests:
dart pub getis blocked by network firewall in this sandbox environment. Formatting changes are purely cosmetic and cannot affect test outcomes; the test suite passed on master before either file was formatted. CI will run on this PR once a maintainer triggers it (see note in #80 aboutgithub-actions[bot]PRs not auto-triggering CI).Format check: verified locally —
dart format --output=none --set-exit-if-changed .now exits 0.Warning
The following domain was blocked by the firewall during workflow execution:
pub.dev