chore: setup playwright#972
Closed
ojeytonwilliams wants to merge 6 commits into
Closed
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Member
|
Meh! I really do not want to add any E2E here, especially playwright. |
Contributor
Author
|
How about a unit test instead? Also, if we were to e2e test, what were you thinking if not playwright? |
Member
Sure.
🛑 Nope, this static site doesn't need all that. |
Contributor
Author
|
Since we're not going with playwright, I'll create another PR just to unit test the redirection. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist:
Update index.md)I'm not sure how much e2e testing we will want, but I figured some simple tests would be helpful.
The unit tests were not really testing anything, since they did not import anything to test, but the e2e tests cover some of the logic that it looked like they were intended to cover.