fix: challenge view bugs#1603
Merged
Merged
Conversation
Member
Author
|
There's still one more bug - if user logs in from the pass widget then the completion percentage is not updated to the right value This bug is also present in the current prod version of the app also |
Member
|
Hey Niraj, I just realized that there is a I'm not suggesting we make the change here, just wanted to mention it as I was hovering on the ChallengeFile class and noticed it 🙂 |
Member
|
Do you want to fix that one as well then in this pr @Nirajn2311 ? |
Member
Author
|
Yea I'll fix it in this PR |
Co-authored-by: Huyen Nguyen <25715018+huyenltnguyen@users.noreply.github.com>
be3150a to
d149bb7
Compare
Member
Author
|
This PR's done |
huyenltnguyen
approved these changes
Jul 15, 2025
18 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist:
mainbranch of the repo.Root cause of the reset code bug - https://arc.net/l/quote/bbawfrzp
The localhost server is not shutdown before the new one is created as the previous view is not disposed until the new one is loaded when we use
pushReplacement