Skip to content

fix: challenge view bugs#1603

Merged
huyenltnguyen merged 10 commits into
freeCodeCamp:mainfrom
Nirajn2311:fix/reset-code-bug
Jul 15, 2025
Merged

fix: challenge view bugs#1603
huyenltnguyen merged 10 commits into
freeCodeCamp:mainfrom
Nirajn2311:fix/reset-code-bug

Conversation

@Nirajn2311
Copy link
Copy Markdown
Member

@Nirajn2311 Nirajn2311 commented Jul 8, 2025

Checklist:

Root cause of the reset code bug - https://arc.net/l/quote/bbawfrzp

The localhost server is not shutdown before the new one is created as the previous view is not disposed until the new one is loaded when we use pushReplacement

@Nirajn2311 Nirajn2311 requested a review from a team July 8, 2025 17:55
Comment thread mobile-app/lib/utils/helpers.dart Outdated
@Nirajn2311 Nirajn2311 changed the title fix: reset code bug fix: challenge view bugs Jul 9, 2025
@Nirajn2311
Copy link
Copy Markdown
Member Author

Nirajn2311 commented Jul 9, 2025

There's still one more bug - if user logs in from the pass widget then the completion percentage is not updated to the right value

This bug is also present in the current prod version of the app also

@huyenltnguyen
Copy link
Copy Markdown
Member

Hey Niraj, I just realized that there is a fileKey property that we could perhaps use in place of having to manually write ${name}.${ext}. fileKey is basically ${name}${ext} (without the dot) but provided by the challenge JSON so we can just consume directly.

I'm not suggesting we make the change here, just wanted to mention it as I was hovering on the ChallengeFile class and noticed it 🙂

@Sembauke
Copy link
Copy Markdown
Member

Do you want to fix that one as well then in this pr @Nirajn2311 ?

@Nirajn2311
Copy link
Copy Markdown
Member Author

Yea I'll fix it in this PR

@Nirajn2311 Nirajn2311 force-pushed the fix/reset-code-bug branch from be3150a to d149bb7 Compare July 12, 2025 06:32
@Nirajn2311
Copy link
Copy Markdown
Member Author

This PR's done

@Nirajn2311 Nirajn2311 requested a review from huyenltnguyen July 13, 2025 05:51
@Nirajn2311 Nirajn2311 added the status: waiting review Waiting for review label Jul 13, 2025
@huyenltnguyen huyenltnguyen merged commit 75d1f4c into freeCodeCamp:main Jul 15, 2025
3 of 6 checks passed
@Nirajn2311 Nirajn2311 deleted the fix/reset-code-bug branch July 16, 2025 01:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status: waiting review Waiting for review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants