Skip to content

fix(view): handle missing challenge video #1622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Nirajn2311 merged 2 commits into from
Jul 16, 2025
Merged

fix(view): handle missing challenge video #1622

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0b7d3fb
fix(view): add videoId null check
huyenltnguyen Jul 15, 2025
1cb45ca
fix(view): display transcript as plain text if video is unvailable
huyenltnguyen Jul 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions mobile-app/lib/ui/views/learn/challenge/templates/multiple_choice/multiple_choice_view.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,7 @@ class MultipleChoiceView extends StatelessWidget {
title: 'Transcript',
child: Transcript(
transcript: challenge.transcript,
isCollapsible: challenge.videoId != null,
),
),
],
Expand Down
12 changes: 7 additions & 5 deletions mobile-app/lib/ui/views/learn/challenge/templates/python/python_view.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,18 +68,20 @@ class PythonView extends StatelessWidget {
),
),
const SizedBox(height: 12),
ChallengeCard(
title: 'Video',
child: YoutubePlayerWidget(
videoId: challenge.videoId!,
if (challenge.videoId != null)
ChallengeCard(
title: 'Video',
child: YoutubePlayerWidget(
videoId: challenge.videoId!,
),
),
),
const SizedBox(height: 12),
if (challenge.transcript.isNotEmpty) ...[
ChallengeCard(
title: 'Transcript',
child: Transcript(
transcript: challenge.transcript,
isCollapsible: challenge.videoId != null,
),
),
],
Expand Down
1 change: 1 addition & 0 deletions mobile-app/lib/ui/views/learn/challenge/templates/review/review_view.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,7 @@ class ReviewView extends StatelessWidget {
title: 'Transcript',
child: Transcript(
transcript: challenge.transcript,
isCollapsible: challenge.videoId != null,
),
),
],
Expand Down
43 changes: 27 additions & 16 deletions mobile-app/lib/ui/views/learn/widgets/transcript_widget.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,29 +5,40 @@ class Transcript extends StatelessWidget {
const Transcript({
super.key,
required this.transcript,
this.isCollapsible = true,
});

final String transcript;
final bool isCollapsible;

@override
Widget build(BuildContext context) {
HTMLParser parser = HTMLParser(context: context);

return ExpansionTile(
backgroundColor: Colors.transparent,
collapsedBackgroundColor: Colors.transparent,
title: const Text('Tap to expand'),
shape: const RoundedRectangleBorder(
side: BorderSide.none,
borderRadius: BorderRadius.zero,
),
collapsedShape: const RoundedRectangleBorder(
side: BorderSide.none,
borderRadius: BorderRadius.zero,
),
children: [
...parser.parse(transcript),
],
);
if (isCollapsible) {
return ExpansionTile(
backgroundColor: Colors.transparent,
collapsedBackgroundColor: Colors.transparent,
title: const Text('Tap to expand'),
shape: const RoundedRectangleBorder(
side: BorderSide.none,
borderRadius: BorderRadius.zero,
),
collapsedShape: const RoundedRectangleBorder(
side: BorderSide.none,
borderRadius: BorderRadius.zero,
),
children: [
...parser.parse(transcript),
],
);
} else {
return Column(
crossAxisAlignment: CrossAxisAlignment.start,
children: [
...parser.parse(transcript),
],
);
}
}
}
Loading