i915: point to fwget(8) for firmware install#460
Open
bzfbd wants to merge 1 commit into
Open
Conversation
Rather than pointing to manually install a package which will install all poossible gpu-firmware, point to fwget(8) which should install the appropriate firmware for the device. Issue: freebsd#346
dumbbell
requested changes
Jun 1, 2026
Member
dumbbell
left a comment
dumbbell
left a comment
There was a problem hiding this comment.
The patch looks good to me and that’s a good idea.
Could you please fix the compilation error described below?
| #elif defined(__FreeBSD__) | ||
| drm_notice(&i915->drm, "Run pkg install gpu-firmware-kmod" \ | ||
| " to install it\n"); | ||
| drm_notice(&dev_priv->drm, "Run fwget(8) to install the " |
Member
There was a problem hiding this comment.
The correct variable is i915 instead of dev_priv. I suppose your patch predates some changes to the driver. They frequently refactor the code.
Could you please fix this?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rather than pointing to manually install a package which will install all poossible gpu-firmware, point to fwget(8) which should install the appropriate firmware for the device.
Issue: #346